| Summary: | segfault when switching to unscanned partition | ||
|---|---|---|---|
| Product: | [Applications] filelight | Reporter: | Jan Wiele <jan> |
| Component: | general | Assignee: | Martin Sandsmark <martin.sandsmark> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kdebugs, rundhis |
| Priority: | NOR | ||
| Version: | 17.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/filelight/4cc7c44589f07f0f5294f8ed6f0b71d20699cd1e | Version Fixed In: | |
| Attachments: |
backtrace
Full backtrace with log |
||
Created attachment 113887 [details]
Full backtrace with log
I have attached full backtrace. Filelight and qt5 had been compiled with debug symbols.
I get no crash when selecting a different partition via the URL textline, but just an empty "0B" circle. Then hitting "Rescan" works. Git commit 4cc7c44589f07f0f5294f8ed6f0b71d20699cd1e by Harald Sitter, on behalf of Szymon Janus. Committed on 04/03/2019 at 16:12. Pushed by sitter into branch 'Applications/18.12'. Fix use after free in RadialMap::Widget::invalidate() Summary: Emit aboutToEmptyCache to invoke RadialMap::Widget::invalidate(), so folder can be safely deleted. If "Scan across system boundaries" isn't set and there is mountpoint B contained in another mountpoint A, user may trigger segfault if scan of A and then B is requested. It is caused by call of MainWindow class to m_map->invalidate() method, which is invoked after m_map's m_tree member is deleted during ScanManager::start method. This fix causes that RadialMap::Widget::invalidate() is called twice in fact, however second call is fine, because "invalidate" is guarded by "isValid" method. Reviewers: sitter, sandsmark Reviewed By: sitter Subscribers: kde-utils-devel Differential Revision: https://phabricator.kde.org/D11188 M +1 -0 src/scan.cpp https://commits.kde.org/filelight/4cc7c44589f07f0f5294f8ed6f0b71d20699cd1e *** Bug 404840 has been marked as a duplicate of this bug. *** |
Created attachment 109942 [details] backtrace When I open filelight (17.12.1) and select / for scanning everything is fine. When I then want to scan /home by entering the path into the textfield in the top right and start the scan with <enter>, filelight crashes. Scanning /home right at the start works fine. I have attached a backtrace.