Bug 388963

Summary: qif importer fails with "you need to call KMyMoneySettings::instance before using"
Product: [Applications] kmymoney Reporter: Alexandre <alexandref75>
Component: importerAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: RESOLVED FIXED    
Severity: crash    
Priority: NOR    
Version: git (master)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Patch to 5.0 branch that fix settings for QIF importer

Description Alexandre 2018-01-14 14:51:29 UTC
Created attachment 109859 [details]
Patch to 5.0 branch that fix settings for QIF importer

QIF importer is reporting the error "you need to call KMyMoneySettings::instance before using" after showing the file selector dialog. The patch that I attached fixed the problem but I do not think it is using the new global settings. Please revise it.
Comment 1 Thomas Baumgart 2018-01-23 07:12:22 UTC
Git commit 2d3c8b6e981b135be8a0a206b998539fbacdb689 by Thomas Baumgart.
Committed on 23/01/2018 at 07:12.
Pushed by tbaumgart into branch '5.0'.

Force usage of global settings in plugins

Since the plugins are shared objects also, we need to inject the global
settings object in the same way as has been implemented with commit
5a1b6235c8ed0775f9f7ade3f274678c1ddfa268

M  +3    -0    kmymoney/pluginloader.cpp
M  +6    -0    kmymoney/plugins/checkprinting/checkprinting.cpp
M  +2    -0    kmymoney/plugins/checkprinting/checkprinting.h
M  +7    -0    kmymoney/plugins/csv/export/csvexporter.cpp
M  +2    -0    kmymoney/plugins/csv/export/csvexporter.h
M  +6    -0    kmymoney/plugins/csv/import/csvimporter.cpp
M  +2    -0    kmymoney/plugins/csv/import/csvimporter.h
M  +6    -0    kmymoney/plugins/gnc/import/gncimporter.cpp
M  +3    -1    kmymoney/plugins/gnc/import/gncimporter.h
M  +6    -0    kmymoney/plugins/icalendar/export/icalendarexporter.cpp
M  +2    -0    kmymoney/plugins/icalendar/export/icalendarexporter.h
M  +6    -0    kmymoney/plugins/kbanking/kbanking.cpp
M  +2    -0    kmymoney/plugins/kbanking/kbanking.h
M  +3    -0    kmymoney/plugins/kmymoneyplugin.h
M  +6    -0    kmymoney/plugins/ofx/import/ofximporter.cpp
M  +3    -1    kmymoney/plugins/ofx/import/ofximporter.h
M  +7    -0    kmymoney/plugins/qif/export/qifexporter.cpp
M  +3    -1    kmymoney/plugins/qif/export/qifexporter.h
M  +6    -0    kmymoney/plugins/qif/import/qifimporter.cpp
M  +3    -1    kmymoney/plugins/qif/import/qifimporter.h
M  +6    -0    kmymoney/plugins/reconciliationreport/reconciliationreport.cpp
M  +2    -0    kmymoney/plugins/reconciliationreport/reconciliationreport.h
M  +6    -0    kmymoney/plugins/weboob/weboob.cpp
M  +2    -0    kmymoney/plugins/weboob/weboob.h

https://commits.kde.org/kmymoney/2d3c8b6e981b135be8a0a206b998539fbacdb689