Bug 388899

Summary:	Assigning color labels from right side menu is different than over context menu
Product:	[Applications] digikam	Reporter:	kowalevskaja
Component:	Albums-ItemGroup	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	CLOSED FIXED
Severity:	normal	CC:	caulier.gilles, kde.bugs, matze69, metzpinguin
Priority:	NOR
Version:	5.7.0
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/41fe3171755581224295e038648834ef0170d82d	Version Fixed In:	7.2.0
Sentry Crash Report:

Description kowalevskaja 2018-01-13 10:02:20 UTC

Applying color labels over the menu on the right side ignores the setting to ask, whether to write metadata to all members of the group. The label is silently applied to all members. In my opinion this is wrong behaviour.
Applying color labels over the context menu (after a right-click) correctly asks, whether to apply the label to all members of the group. This is the behaviour I expected.

Comment 1 caulier.gilles 2020-08-04 08:21:07 UTC

digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Best Regards

Gilles Caulier

Comment 2 Maik Qualmann 2020-10-29 14:19:38 UTC

*** Bug 428427 has been marked as a duplicate of this bug. ***

Comment 3 meku 2020-10-30 08:28:58 UTC

Testing 7.0.0 - 7.2.0-beta1 I have not found any of these versions use the setting [Miscellaneous >> Grouping >> Metadata >> Perform operations on all group members] when applying the right side Captions widget.

In 7.0.0 it always operated on all group members.

In 7.1.0 and later it never operates on group members.

I had this setting on 'Yes' to silently operate on all group members so did not notice this bug until the behaviour changed in 7.1.0

Comment 4 Maik Qualmann 2020-10-31 07:52:52 UTC

Git commit 41fe3171755581224295e038648834ef0170d82d by Maik Qualmann.
Committed on 31/10/2020 at 07:51.
Pushed by mqualmann into branch 'master'.

apply the setting for grouped items in the setup
Related: bug 428427
FIXED-IN: 7.2.0

M  +3    -1    NEWS
M  +3    -1    core/app/views/stack/itemiconview_items.cpp

https://invent.kde.org/graphics/digikam/commit/41fe3171755581224295e038648834ef0170d82d

Comment 5 Maik Qualmann 2020-10-31 07:57:12 UTC

The "Ask" option is not possible here, since it must be decided at the selection whether grouped elements should be included. Since the tag state has to be set accordingly and we don't want to see a dialog when making the selection. The "Ask" option is rated internally as "No" for grouped elements.

Maik

Comment 6 Maik Qualmann 2020-11-24 21:45:36 UTC

*** Bug 429604 has been marked as a duplicate of this bug. ***

Comment 7 kowalevskaja 2023-04-22 19:38:39 UTC

(In reply to Maik Qualmann from comment #5)
> The "Ask" option is not possible here, since it must be decided at the
> selection whether grouped elements should be included. Since the tag state
> has to be set accordingly and we don't want to see a dialog when making the
> selection. The "Ask" option is rated internally as "No" for grouped elements.
> 
> Maik

Many thanks for your work on this issue! I just went through the process again with version 7.10.0.
To me, your implementation fixed the situation and your comment perfectly explains why the "ask" option cannot be respected when going over the right hand side menu. Great work, thanks.