Bug 388794

Summary:	Unable to click on painting assistant's control buttons when Mirror View is activated
Product:	[Applications] krita	Reporter:	Nabil Maghfur usman <nmaghfurusman>
Component:	Tool/Assistants	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	rjquiralte, scottpetrovic
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/krita/14841a10b1f9e19e59b0e95fd203393399f3e17e	Version Fixed In:
Sentry Crash Report:

Description Nabil Maghfur usman 2018-01-10 21:02:08 UTC

The 3 buttons to move/toggle/delete an assistant are always displayed right-of-center on the assistant, but when Mirror View is on, their "hitboxes" are actually left-of-center even though the buttons themselves are being displayed right-of-center.

Steps to reproduce:
1. Create new document
2. Place an assistant somewhere
3. Activate Mirror View
4. Click on the assistant's delete button

Expected Result:
Assistant is deleted

Actual Result:
A new assistant will be placed where the previous assistant's delete button is displayed

Comment 1 Quiralta 2018-01-10 22:11:21 UTC

I can reproduce this bug, and its been there for a few days.

Finally figure out what was happening, I thought it was my tablet, this bug not only is present on mirror view but also on rotated canvas, the buttons to "close", "move" and "hide" the assistants are not click-able, as Wysteria points out, it will create a new assistant as if there was no buttons there, once the canvas is reset all works normally.

Same ways to reproduce, just rotate the canvas a little. Also on git master build.

Comment 2 Scott Petrovic 2018-01-11 10:46:11 UTC

This is a regression. I tested it on 3.3.2 and it works ok there

Comment 3 Scott Petrovic 2018-01-11 13:25:12 UTC

Git commit 14841a10b1f9e19e59b0e95fd203393399f3e17e by Scott Petrovic.
Committed on 11/01/2018 at 13:24.
Pushed by scottpetrovic into branch 'master'.

M  +11   -4    plugins/assistants/Assistants/kis_assistant_tool.cc

https://commits.kde.org/krita/14841a10b1f9e19e59b0e95fd203393399f3e17e

Comment 4 Scott Petrovic 2018-01-11 13:27:38 UTC

It should work now if you pull master. For those UI controls, I am stopping it from mirroring and rotating all those UI controls. The controls should always appear horizontally now in the same order.

And...the buttons should be clickable now when mirrored.