Bug 388779

Summary: keep frame selection active at all times
Product: [Applications] krita Reporter: Bollebib <kwadraatnope>
Component: AnimationAssignee: Emmet O'Neill <emmetoneill.pdx>
Status: RESOLVED FIXED    
Severity: wishlist CC: emmetoneill.pdx, tamtamy.tymona
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:

Description Bollebib 2018-01-10 13:22:08 UTC
when you make frame selection and want to check a certain frame ,or just go to next or previous frame ,the selection is lost


I feel this should not happen.


It wastes time,and it increases the amount of actions you should do if you need to redo that selection

Scrubbing,browisng should not influence the selection.
Comment 1 Emmet O'Neill 2020-04-14 19:08:56 UTC
Hey again. I understand what you're asking for, but if you have time, can you make a quick demo to help me understand the use case for this?

(Decoupling the preview from the selection entirely might add a layer of complexity to the Timeline's UI and code. So I think it really needs to be worth it.)
Comment 2 Bollebib 2020-04-14 20:23:43 UTC
https://youtu.be/L5nPyIUFoLk


usually scenes are much more complex than what i show in this demo


so having selection be predictable and not unselect at whim is very useful




I guess a single undo to go back to last selection would be workable too if the other way is too hard. Not ideal, but workable
Comment 3 Bug Janitor Service 2020-04-15 04:33:10 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Eoin O'Neill 2020-07-29 03:40:42 UTC
Git commit d76c59fca3fad96ddf299b4f36d951fb10105259 by Eoin O'Neill.
Committed on 29/07/2020 at 03:40.
Pushed by eoinoneill into branch 'krita/4.3'.

Fix: Properly Maintain Selection of Keyframes When Inserting / Removing Hold Frames.

Related Feature: Preserve multi-frame selection when active frame changes. Useful
for preserving the users selection on scrub, but also less error-prone when dealing
with modifying the user selection while concurrent "switch-time" operation is running.

Insert Keyframe Bug:
Related: bug 404519

Maintain Multiframe Selection Wishlist:

M  +1    -1    plugins/dockers/animation/timeline_frames_model.cpp
M  +1    -1    plugins/dockers/animation/timeline_frames_model.h
M  +37   -1    plugins/dockers/animation/timeline_frames_view.cpp
M  +1    -0    plugins/dockers/animation/timeline_frames_view.h

https://invent.kde.org/graphics/krita/commit/d76c59fca3fad96ddf299b4f36d951fb10105259
Comment 5 Eoin O'Neill 2020-07-29 05:26:48 UTC
Git commit 68a0cf3e32e6ad857ac275a65a5719930bad74cd by Eoin O'Neill.
Committed on 29/07/2020 at 03:42.
Pushed by eoinoneill into branch 'master'.

Fix: Properly Maintain Selection of Keyframes When Inserting / Removing Hold Frames.

Related Feature: Preserve multi-frame selection when active frame changes. Useful
for preserving the users selection on scrub, but also less error-prone when dealing
with modifying the user selection while concurrent "switch-time" operation is running.

Insert Keyframe Bug:
Related: bug 404519

Maintain Multiframe Selection Wishlist:

(commit cherry-picked from krita/4.3 d76c59fca3fad96ddf299b4f36d951fb10105259)

M  +1    -1    plugins/dockers/animation/timeline_frames_model.cpp
M  +1    -1    plugins/dockers/animation/timeline_frames_model.h
M  +36   -0    plugins/dockers/animation/timeline_frames_view.cpp
M  +1    -0    plugins/dockers/animation/timeline_frames_view.h

https://invent.kde.org/graphics/krita/commit/68a0cf3e32e6ad857ac275a65a5719930bad74cd