Bug 388707

Summary:	Add Hot pixel removal in Batch Queue Manager Workflow
Product:	[Applications] digikam	Reporter:	warpdrive50
Component:	Plugin-Bqm-HotPixels	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	5.6.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/c09182b30d656b2e68f7458cc412a84e32a46359	Version Fixed/Implemented In:	7.1.0
Sentry Crash Report:

Description warpdrive50 2018-01-09 03:27:22 UTC

The hot pixel tool from the "enhancement" section is not available as a workflow step in the batch processing tool.
I would like to suggest to provide it.

Comment 1 caulier.gilles 2020-08-05 11:45:25 UTC

Git commit 67224fea2d98e493ac7ee15c6c01417f5ed3f127 by Gilles Caulier.
Committed on 05/08/2020 at 11:43.
Pushed by cgilles into branch 'master'.

First stage to factorize HotPixels classes to be shared between Image Editor and BQM.

M  +1    -5    core/dplugins/editor/enhance/hotpixels/CMakeLists.txt
D  +0    -106  core/dplugins/editor/enhance/hotpixels/hotpixel.h
M  +5    -0    core/libs/dimg/CMakeLists.txt
R  +0    -0    core/libs/dimg/filters/hotpixels/TODO [from: core/dplugins/editor/enhance/hotpixels/TODO - 100% similarity]
R  +2    -2    core/libs/dimg/filters/hotpixels/blackframelistview.cpp [from: core/dplugins/editor/enhance/hotpixels/blackframelistview.cpp - 098% similarity]
R  +9    -8    core/libs/dimg/filters/hotpixels/blackframelistview.h [from: core/dplugins/editor/enhance/hotpixels/blackframelistview.h - 085% similarity]
R  +2    -2    core/libs/dimg/filters/hotpixels/blackframeparser.cpp [from: core/dplugins/editor/enhance/hotpixels/blackframeparser.cpp - 098% similarity]
R  +7    -6    core/libs/dimg/filters/hotpixels/blackframeparser.h [from: core/dplugins/editor/enhance/hotpixels/blackframeparser.h - 089% similarity]
A  +87   -0    core/libs/dimg/filters/hotpixels/hotpixel.cpp     [License: GPL (v2+)]
A  +63   -0    core/libs/dimg/filters/hotpixels/hotpixel.h     [License: GPL (v2+)]
R  +2    -2    core/libs/dimg/filters/hotpixels/hotpixelfixer.cpp [from: core/dplugins/editor/enhance/hotpixels/hotpixelfixer.cpp - 099% similarity]
R  +7    -6    core/libs/dimg/filters/hotpixels/hotpixelfixer.h [from: core/dplugins/editor/enhance/hotpixels/hotpixelfixer.h - 092% similarity]
R  +2    -2    core/libs/dimg/filters/hotpixels/hotpixelsweights.cpp [from: core/dplugins/editor/enhance/hotpixels/hotpixelsweights.cpp - 099% similarity]
R  +11   -6    core/libs/dimg/filters/hotpixels/hotpixelsweights.h [from: core/dplugins/editor/enhance/hotpixels/hotpixelsweights.h - 092% similarity]

https://invent.kde.org/graphics/digikam/commit/67224fea2d98e493ac7ee15c6c01417f5ed3f127

Comment 2 caulier.gilles 2020-08-05 14:38:06 UTC

Git commit 495b01e04213c7758c5b362b0602dff90f386c18 by Gilles Caulier.
Committed on 05/08/2020 at 14:37.
Pushed by cgilles into branch 'master'.

Stage 2 : prepare HotPixel tool to handle generic settings container

M  +3    -0    core/libs/dimg/CMakeLists.txt
M  +1    -0    core/libs/dimg/filters/README
A  +78   -0    core/libs/dimg/filters/bcg/bcgcontainer.cpp     [License: GPL (v2+)]
M  +0    -43   core/libs/dimg/filters/bcg/bcgfilter.cpp
A  +67   -0    core/libs/dimg/filters/hotpixels/hotpixelcontainer.cpp     [License: GPL (v2+)]
A  +63   -0    core/libs/dimg/filters/hotpixels/hotpixelcontainer.h     [License: GPL (v2+)]
A  +199  -0    core/libs/dimg/filters/hotpixels/hotpixelsettings.cpp     [License: GPL (v2+)]
A  +71   -0    core/libs/dimg/filters/hotpixels/hotpixelsettings.h     [License: GPL (v2+)]

https://invent.kde.org/graphics/digikam/commit/495b01e04213c7758c5b362b0602dff90f386c18

Comment 3 caulier.gilles 2020-08-05 15:07:26 UTC

Git commit b875a044454579f276374f545299f3058287b779 by Gilles Caulier.
Committed on 05/08/2020 at 15:06.
Pushed by cgilles into branch 'master'.

Stage3: rename HotPixel class as HotPixelProps (aka properties)

M  +9    -9    core/dplugins/editor/enhance/hotpixels/hotpixelstool.cpp
M  +2    -2    core/dplugins/editor/enhance/hotpixels/hotpixelstool.h
M  +1    -1    core/libs/dimg/CMakeLists.txt
M  +8    -8    core/libs/dimg/filters/hotpixels/blackframelistview.cpp
M  +12   -12   core/libs/dimg/filters/hotpixels/blackframelistview.h
M  +9    -9    core/libs/dimg/filters/hotpixels/blackframeparser.cpp
M  +4    -4    core/libs/dimg/filters/hotpixels/blackframeparser.h
M  +12   -12   core/libs/dimg/filters/hotpixels/hotpixelfixer.cpp
M  +6    -6    core/libs/dimg/filters/hotpixels/hotpixelfixer.h
R  +8    -8    core/libs/dimg/filters/hotpixels/hotpixelprops.cpp [from: core/libs/dimg/filters/hotpixels/hotpixel.cpp - 086% similarity]
R  +6    -6    core/libs/dimg/filters/hotpixels/hotpixelprops.h [from: core/libs/dimg/filters/hotpixels/hotpixel.h - 085% similarity]

https://invent.kde.org/graphics/digikam/commit/b875a044454579f276374f545299f3058287b779

Comment 4 caulier.gilles 2020-08-05 21:46:19 UTC

Git commit b205d0831f5476f914e65b0a0b899b6175a46731 by Gilles Caulier.
Committed on 05/08/2020 at 21:45.
Pushed by cgilles into branch 'master'.

Implement hot pixel settings pass 1

M  +3    -4    core/dplugins/editor/enhance/hotpixels/hotpixelstool.cpp
M  +57   -83   core/libs/dimg/filters/hotpixels/hotpixelsettings.cpp

https://invent.kde.org/graphics/digikam/commit/b205d0831f5476f914e65b0a0b899b6175a46731

Comment 5 caulier.gilles 2020-08-07 13:40:27 UTC

Git commit fa9a44242c2124cc62b21ce01c281afbfcb04d06 by Gilles Caulier.
Committed on 07/08/2020 at 13:39.
Pushed by cgilles into branch 'master'.

Port Image Editor HotPixel to shared API for BQM uses.
Fix crash while hot pixels parsing and consolidate list

M  +28   -153  core/dplugins/editor/enhance/hotpixels/hotpixelstool.cpp
M  +2    -4    core/dplugins/editor/enhance/hotpixels/hotpixelstool.h
M  +22   -25   core/libs/dimg/filters/hotpixels/blackframeparser.cpp
M  +2    -2    core/libs/dimg/filters/hotpixels/blackframeparser.h
M  +1    -1    core/libs/dimg/filters/hotpixels/hotpixelcontainer.cpp
M  +1    -1    core/libs/dimg/filters/hotpixels/hotpixelcontainer.h
M  +13   -15   core/libs/dimg/filters/hotpixels/hotpixelprops.cpp
M  +5    -3    core/libs/dimg/filters/hotpixels/hotpixelprops.h

https://invent.kde.org/graphics/digikam/commit/fa9a44242c2124cc62b21ce01c281afbfcb04d06

Comment 6 caulier.gilles 2020-08-07 15:22:30 UTC

Git commit c09182b30d656b2e68f7458cc412a84e32a46359 by Gilles Caulier.
Committed on 07/08/2020 at 15:21.
Pushed by cgilles into branch 'master'.

Batch Queue Manager : add new tool to fix hot pixels from images.
FIXED-IN: 7.1.0

M  +4    -2    NEWS
M  +1    -0    core/dplugins/bqm/enhance/CMakeLists.txt
A  +26   -0    core/dplugins/bqm/enhance/hotpixels/CMakeLists.txt
A  +113  -0    core/dplugins/bqm/enhance/hotpixels/hotpixels.cpp     [License: GPL (v2+)]
A  +68   -0    core/dplugins/bqm/enhance/hotpixels/hotpixels.h     [License: GPL (v2+)]
A  +97   -0    core/dplugins/bqm/enhance/hotpixels/hotpixelsplugin.cpp     [License: GPL (v2+)]
A  +60   -0    core/dplugins/bqm/enhance/hotpixels/hotpixelsplugin.h     [License: GPL (v2+)]
M  +1    -1    core/dplugins/editor/TODO
M  +0    -1    core/libs/dimg/filters/hotpixels/hotpixelsettings.h

https://invent.kde.org/graphics/digikam/commit/c09182b30d656b2e68f7458cc412a84e32a46359