Bug 388579

Summary: qca-ossl fails to build with OpenSSL 1.0.1f
Product: [Frameworks and Libraries] qca Reporter: pierre.hallot
Component: generalAssignee: Ivan Romanov <drizt72>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: bradh, justin
Priority: NOR    
Version First Reported In: Git   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description pierre.hallot 2018-01-05 16:45:06 UTC 
Using the latest master with the patch for OpenSSL 1.1, qca fails to build with OpenSSL 1.0.1f.

17:03:25 qca/plugins/qca-ossl/qca-ossl.cpp: In member function 'void opensslQCAPlugin::MyCertContext::make_props()':
17:03:25 qca/plugins/qca-ossl/qca-ossl.cpp:3744:44: error: 'X509_get0_signature' was not declared in this scope
17:03:25    X509_get0_signature(&signature, NULL, x);
17:03:25                                             ^
17:03:25 qca/plugins/qca-ossl/qca-ossl.cpp:3753:35: error: 'X509_get_signature_nid' was not declared in this scope
17:03:25    switch( X509_get_signature_nid(x) )
17:03:25                                    ^
17:03:25 In file included from qca/plugins/qca-ossl/qca-ossl.cpp:43:0:
17:03:25 qca/plugins/qca-ossl/ossl110-compat.h: At global scope:
17:03:25 qca/plugins/qca-ossl/ossl110-compat.h:152:13: warning: 'void X509_SIG_getm(const X509_SIG*, X509_ALGOR**, ASN1_OCTET_STRING**)' defined but not used [-Wunused-function]
17:03:25  static void X509_SIG_getm(const X509_SIG *sig, X509_ALGOR **palg, ASN1_OCTET_STRING **pdigest)
17:03:25              ^
17:03:25 ninja: build stopped: subcommand failed.

According to the OpenSSL doc:
"X509_get0_signature() and X509_get_signature_nid() were first added to OpenSSL 1.0.2."
https://www.openssl.org/docs/man1.1.0/crypto/X509_get_signature_nid.html

Is OpenSSL 1.0.1 not supported anymore?

Thanks.
Comment 1 Christoph Feck 2018-01-09 23:07:16 UTC 
No. OpenSSL 1.0.1f is already 4 years old, and any updates to OpenSSL 1.0.1x have stopped three 3 ago. If you are using an old OpenSSL you should have no problem also using an older QCA.