Summary: | Categories from Flatpak not de-duplicated | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
Component: | Flatpak Backend | Assignee: | Aleix Pol <aleixpol> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | jgrulich |
Priority: | NOR | ||
Version: | 5.11.4 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/discover/2359fe4adb7063b0bed610ad8b085f0a4616a2fc | Version Fixed In: | |
Attachments: |
Categories duplicated after adding Flatpak backend and Flathub source
Still happening in git master |
Works here. Can you run it from the console and check there's no weird warnings? Here's the console output: $ plasma-discover invalid kns backend! "/etc/xdg/ksysguard.knsrc" because: "Config group not found! Check your KNS3 installation." invalid kns backend! "/etc/xdg/servicemenu.knsrc" because: "Config group not found! Check your KNS3 installation." Discarding invalid backend "ksysguard.knsrc" Discarding invalid backend "servicemenu.knsrc" setting currentApplicationBackend PackageKitBackend(0x1c66120) Failed to refresh appstream metadata for flathub : GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Flatpak.SystemHelper was not provided by any .service files Maybe that's a clue? This should be fixed as of db212c8e (master). Created attachment 109746 [details]
Still happening in git master
I'm afraid not. I just built Discover from git master and it's still happening for a few categories (Accessories, Accessibility, Games, Graphics). See attached screenshot.
Git commit 2359fe4adb7063b0bed610ad8b085f0a4616a2fc by Aleix Pol. Committed on 08/01/2018 at 23:59. Pushed by apol into branch 'master'. Make sure we don't treat a non-sorted vector as sorted M +23 -0 libdiscover/Category/Category.cpp M +2 -1 libdiscover/Category/Category.h M +1 -0 libdiscover/Category/CategoryModel.cpp https://commits.kde.org/discover/2359fe4adb7063b0bed610ad8b085f0a4616a2fc Verified, all better now! Thanks! |
Created attachment 109569 [details] Categories duplicated after adding Flatpak backend and Flathub source [Discover from git master] After building the Flatpak backend and adding the Flathub source, Discover shows duplicate categories. It seems that the Flatpak categories are not de-duplicated with PackageKit catagories that have the same name. The duplicate categories all show the same actual source content. If I remove the Flatpak backend, the problem disappears. This seems to have regressed in git master, since in Discover 5.11.4, categories with the same name are never duplicated.