Bug 388260

Summary: Pressing <ENTER> on highlited name when browsing "Unknown" face tags will tag two photos instead of one
Product: [Applications] digikam Reporter: jat255
Component: Faces-WorkflowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: jat255
Priority: NOR    
Version First Reported In: 5.7.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/digikam/c6fdb791a4a21b085d98885d8addf000d095c3ce Version Fixed/Implemented In: 5.8.0
Sentry Crash Report:

Description jat255 2017-12-26 22:38:54 UTC 
After recognizing faces, when browsing through the "Unknown" tag of faces, there is a bug applying tags using the "ENTER" key on the keyboard. If you have a number of faces of the same person in a row, such that the correct name (which is the last used) is the suggested name for the next face tag, pressing ENTER will cause that tag to be assigned to both the currently-highlighted face tag as well as the next one. This is not a problem with multiple tags of the same person, but  can obviously cause problems, as the user is expecting only one tag to be assigned, and not two.

This does not occur when checking the "checkmark" button to confirm the tag, instead occurring only when pressing ENTER to confirm.
Comment 1 jat255 2017-12-26 22:43:32 UTC 
To clarify, if you change the tag by typing another name into the box, pressing ENTER will only assign one tag, as expected. The double-tagging only occurs when pressing ENTER on the name that is first suggested in the tagging box.
Comment 2 Maik Qualmann 2017-12-27 11:31:39 UTC 
Git commit c6fdb791a4a21b085d98885d8addf000d095c3ce by Maik Qualmann.
Committed on 27/12/2017 at 11:30.
Pushed by mqualmann into branch 'master'.

fix double enter input on face tagging
FIXED-IN: 5.8.0

M  +2    -1    NEWS
M  +3    -9    utilities/facemanagement/assignnamewidget.cpp

https://commits.kde.org/digikam/c6fdb791a4a21b085d98885d8addf000d095c3ce
Comment 3 jat255 2017-12-27 21:44:11 UTC 
Wow, thanks Maik for such a quick response and fix! I'll try out a build from git tonight to confirm that all is working as expected.
Comment 4 Maik Qualmann 2017-12-27 21:57:02 UTC 
Git commit b605cf90f07015cb9df0a7270eaf7b027438312f by Maik Qualmann.
Committed on 27/12/2017 at 21:56.
Pushed by mqualmann into branch 'master'.

filter out enter key to prevent preview

M  +8    -3    utilities/facemanagement/assignnamewidget.cpp

https://commits.kde.org/digikam/b605cf90f07015cb9df0a7270eaf7b027438312f