Bug 388256

Summary: Change Shadow Orientation and Levels
Product: [Plasma] Breeze Reporter: Andres Betts <anditosan1000>
Component: generalAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: nate, simonandric5
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/breeze/9fb5d3abb18cde0ef63102cb06f1a936152ccaef Version Fixed/Implemented In:
Sentry Crash Report:

Description Andres Betts 2017-12-26 18:18:06 UTC 
I feel the shadows on Breeze can use some editing. In working with shadows I noticed that the default has almost 0 shadow on the top and left side of the window. This means that the orientation and size of the shadow is small. When placing two windows overlapping you can't really tell if there is a separation between them, only when you look to the right side. Sometimes the colors overlap and it amounts to an experience in depth that could be improved.

Here is my suggestion:

Shadow size: 35 (or more)
Shadow Strength: 15
Color: 000000

Orientation: left/right should be centered, top/bottom should be offset as it is currently
Comment 1 Nate Graham 2017-12-27 01:24:34 UTC 
There was a patch to add an option for this a few months ago: https://phabricator.kde.org/D8232

I'm in favor of centering the shadow as the new default, rather than as an option.
Comment 2 Nate Graham 2017-12-29 15:47:30 UTC 
Submitted a patch that accomplishes this: https://phabricator.kde.org/D9549
Comment 3 Andres Betts 2017-12-29 15:48:25 UTC 
Yay! Thanks for your work!
Comment 4 Nate Graham 2018-01-02 15:19:13 UTC 
Git commit 9fb5d3abb18cde0ef63102cb06f1a936152ccaef by Nathaniel Graham.
Committed on 02/01/2018 at 15:19.
Pushed by ngraham into branch 'master'.

Horizontally center shadows and make them bigger

Summary:

#VDG has decided that shadows should be horizontally centered and bigger. This patch implements those changes in the following way:
- Window and menu shadows are now horizontally centered
- Shadow size increased to the maximum value
- Shadow color changed from pure black to a slightly lighter Breeze standard color: Shade Black

Test Plan:
Tested in KDE Neon. Before:
{F5587393}

After:
{F5587390}

Reviewers: abetts, hpereiradacosta, #vdg, #breeze, alake

Reviewed By: abetts, hpereiradacosta, #vdg

Subscribers: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D9549

M  +3    -3    kdecoration/breezedecoration.cpp
M  +3    -3    kdecoration/breezesettingsdata.kcfg
M  +1    -1    kstyle/breezemdiwindowshadow.cpp
M  +3    -3    kstyle/breezeshadowhelper.cpp

https://commits.kde.org/breeze/9fb5d3abb18cde0ef63102cb06f1a936152ccaef