Bug 388247

Summary: JJ: Rulers do not subdivide to show more numbers based on zoom level
Product: [Applications] krita Reporter: Isaac Zuniga <isaaczuniga>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: 22shubh22, halla, simeirxh, simonandric5
Priority: NOR Keywords: junior-jobs
Version First Reported In: 3.3.2   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: This just shows a 1x1 grid depicted on the canvas, and nothing more than the "2000" pixel mark.

Description Isaac Zuniga 2017-12-26 14:07:46 UTC
Created attachment 109529 [details]
This just shows a 1x1 grid depicted on the canvas, and nothing more than the "2000" pixel mark.

When I zoom in on my canvas, I notice the numbers on the rulers do not match the grid line measurements when I get closer in. In the picture I attached, I zoomed in between 2000 and 1900 pixels (horizontal) and I do not see the in between numbers.

I'm not sure if this is a bug or if it's just something that was never implemented. I never noticed this before because the pictures I drew were never this big, but when I saw this today, I had to run a test on it to see if I was seeing it correctly.

If this was a feature that was never implemented, feel free to switch the severity to "Wishlist", because it'd be very helpful if the rulers showed numbers in between the vague 2000 and 1900.
Comment 1 Halla Rempt 2017-12-26 15:21:37 UTC
Heh, at first I thought "but there are no rulers on that screenshot" :-) This does look like something that should be picked up, and it should be easy-ish, so I'm confirming and marking as a junior job.
Comment 2 Isaac Zuniga 2017-12-27 06:24:20 UTC
(In reply to Boudewijn Rempt from comment #1)
> Heh, at first I thought "but there are no rulers on that screenshot" :-)
> This does look like something that should be picked up, and it should be
> easy-ish, so I'm confirming and marking as a junior job.

Sounds nice, thanks for your help. I hope to see it implemented in Krita 4.0!
Comment 3 simeirxh 2018-01-20 01:23:09 UTC
(In reply to Boudewijn Rempt from comment #1)
> Heh, at first I thought "but there are no rulers on that screenshot" :-)
> This does look like something that should be picked up, and it should be
> easy-ish, so I'm confirming and marking as a junior job.

Hi Boud,

I wrote some code to solve this problem. Can you tell me how I can submit these code?
Comment 4 Halla Rempt 2018-01-25 08:57:33 UTC
Git commit ba60778bd55071449c56acd78c056623ce7e7ac6 by Boudewijn Rempt.
Committed on 25/01/2018 at 08:54.
Pushed by rempt into branch 'master'.

Change ruler subdivision based on zoom level
Patch by Michael Zhou, thanks!
Differential Revision: https://phabricator.kde.org/D9999

M  +144  -190  libs/widgets/KoRuler.cpp

https://commits.kde.org/krita/ba60778bd55071449c56acd78c056623ce7e7ac6