Bug 388161

Summary: selecting onion skin lightbulb makes Krita unresponsive
Product: [Applications] krita Reporter: Scott Petrovic <scottpetrovic>
Component: AnimationAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: griffinvalley, halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://commits.kde.org/krita/d4ca15238daf94eb89f0d485ab63a499c3220e6d Version Fixed/Implemented In:
Sentry Crash Report:

Description Scott Petrovic 2017-12-23 01:05:41 UTC 
I am on my KDE Neon box with the latest on master. Krita starts to become unresponsive (does not seg fault though) when I do the following:

1. Create a new document
2. Open the timeline docker
3. Add a new keyframe to the timeline
4. Click on the light bulb to enable onion skinning


The light bulb does not turn on...and Krita goes into an unresponsive state.

I moved around to different commits and it seems like the problems starts happening at this commit. 

b180f3c768fc3d4e

Merge remote-tracking branch 'origin/master' into kazakov/lazy-brush
Comment 1 wolthera 2017-12-23 13:44:39 UTC 
Yeah, same here. Seems almost as if an un-exitable for loop was entered.
Comment 2 wolthera 2017-12-23 13:46:08 UTC 
For what it is worth, when doing cntrl+c in gdb when this issue pops up gives the following data:

 ^C
 Thread 1 "krita" received signal SIGINT, Interrupt.
 KisNode::setDirtyDontResetAnimationCache (this=0x12eb6b90, rect=...)
     at /home/wolthera/krita/src/libs/image/kis_node.cpp:611
 611     {
 (gdb)
Comment 3 wolthera 2017-12-23 13:55:01 UTC 
Alright, probably caused by this commit somehow:
https://phabricator.kde.org/R37:36e9e0d5f878e163b169457f42944a0ebdfe392b#change-82il1okkk5tm

I don't know the animation code enough to fix it though...
Comment 4 Dmitry Kazakov 2018-01-16 11:30:03 UTC 
Git commit d4ca15238daf94eb89f0d485ab63a499c3220e6d by Dmitry Kazakov.
Committed on 16/01/2018 at 11:29.
Pushed by dkazakov into branch 'master'.

Fix an infinite loop when trying to activate Onion Skins

M  +2    -2    libs/image/kis_node.cpp

https://commits.kde.org/krita/d4ca15238daf94eb89f0d485ab63a499c3220e6d