Bug 388096

Summary: Last few commits (starting with 4a072216cda0de55dfcb015e43c4a78063cb911f) broke the build
Product: [Applications] Discover Reporter: Nate Graham <nate>
Component: PackageKitAssignee: Aleix Pol <aleixpol>
Status: RESOLVED DUPLICATE    
Severity: critical    
Priority: NOR    
Version First Reported In: 5.11.4   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2017-12-20 22:40:22 UTC
Starting with commit 4a072216cda0de55dfcb015e43c4a78063cb911f, I cannot build in my Neon dev VM:


cmake . -DCMAKE_INSTALL_PREFIX=/opt/discover/ && make && sudo make install && source ~/.kderc && /opt/discover/bin/plasma-discover

[...]

[ 61%] Building CXX object libdiscover/backends/PackageKitBackend/CMakeFiles/DiscoverPackageKitNotifier.dir/PackageKitNotifier.cpp.o
/home/dev/repos/discover/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp: In lambda function:
/home/dev/repos/discover/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp:149:9: error: ‘upgradeSystem’ is not a member of ‘PackageKit::Daemon’
         PackageKit::Daemon::upgradeSystem(name, PackageKit::Transaction::Upgra
         ^
/home/dev/repos/discover/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp:149:49: error: ‘UpgradeKindDefault’ is not a member of ‘PackageKit::Transaction’
         PackageKit::Daemon::upgradeSystem(name, PackageKit::Transaction::Upgra
                                                 ^
/home/dev/repos/discover/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp: In member function ‘void PackageKitNotifier::refreshDatabase()’:
/home/dev/repos/discover/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp:165:59: error: ‘RoleUpgradeSystem’ is not a member of ‘PackageKit::Transaction’
     if (!m_distUpgrades && (PackageKit::Daemon::roles() & PackageKit::Transact
                                                           ^
libdiscover/backends/PackageKitBackend/CMakeFiles/DiscoverPackageKitNotifier.dir/build.make:62: recipe for target 'libdiscover/backends/PackageKitBackend/CMakeFiles/DiscoverPackageKitNotifier.dir/PackageKitNotifier.cpp.o' failed
make[2]: *** [libdiscover/backends/PackageKitBackend/CMakeFiles/DiscoverPackageKitNotifier.dir/PackageKitNotifier.cpp.o] Error 1
CMakeFiles/Makefile2:494: recipe for target 'libdiscover/backends/PackageKitBackend/CMakeFiles/DiscoverPackageKitNotifier.dir/all' failed
make[1]: *** [libdiscover/backends/PackageKitBackend/CMakeFiles/DiscoverPackageKitNotifier.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2



I've got packagekit-qt5 0.9.5. Rolling back to 5ac9d0b740279f8ed32778cbff23ce74a04a8907 allows me to build Discover again.
Comment 1 Aleix Pol 2017-12-20 23:20:41 UTC

*** This bug has been marked as a duplicate of bug 388093 ***