Bug 388076

Summary: Unnecessary notification message shown when canceling password prompt
Product: [Applications] Discover Reporter: Nate Graham <nate>
Component: discoverAssignee: Aleix Pol <aleixpol>
Status: RESOLVED INTENTIONAL    
Severity: minor CC: bugseforuns
Priority: NOR    
Version: 5.11.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=390959
https://bugs.kde.org/show_bug.cgi?id=438131
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Unnecessary message shown after canceling password prompt

Description Nate Graham 2017-12-20 14:57:19 UTC 
STEPS TO REPRODUCE
1. Initiate any operation that requires authorization
2. Cancel the password prompt

EXPECTED RESULTS
The password dialogs disappears and that's the end of it

ACTUAL RESULTS
The password dialog disappears, but then a little bubble message appears complaining about no authorization. There's no need to show this:
- When the password dialog was purposely dismissed, user doesn't need a complainey notification telling them about something they decided to do
- When the password is entered incorrectly, the password dialog supplies its own "that was the wrong password, try again" message
Comment 1 Nate Graham 2017-12-20 14:58:05 UTC 
Created attachment 109461 [details]
Unnecessary message shown after canceling password prompt
Comment 2 Aleix Pol 2018-01-08 19:10:59 UTC 
The problem exists, but there's not much we can do about it ATM. The UI comes from PolicyKit through PackageKit, the response we get is ErrorNotAuthorized.
Comment 3 Nate Graham 2021-04-07 19:09:30 UTC 
Well we can just eat this error and not display it to the user, right?

1. If the error comes from the user purposely dismissing the dialog, we don't need to annoy them with another message

2. If the error comes from the user entering their password incorrectly multiple times, the dialog has already told them what the problem is.
Comment 4 Bug Janitor Service 2021-04-07 19:15:05 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/104
Comment 5 Nate Graham 2021-05-26 19:48:08 UTC 
There was no agreement on my proposed change. Closing.