Bug 387997

Summary: Zooming results in "Edit guides" history entry
Product: [Applications] krita Reporter: Storm Engineer <storm.anthro>
Component: GeneralAssignee: Thorsten Zachmann <mo>
Status: RESOLVED FIXED    
Severity: normal CC: halla, nicholaslapointe8, rjquiralte
Priority: NOR Keywords: release_blocker
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/krita/008d4977309776b496a7f38b0764a97bfddc5a8a Version Fixed In:
Sentry Crash Report:

Description Storm Engineer 2017-12-18 05:41:54 UTC 
Zooming after making brushstrokes results in an "Edit guides" entry in undo history, even for documents that do not have any guides.

To reproduce:
1; make a brushstroke
2; Zoom canvas in or out.

Just built from Master.
Comment 1 Quiralta 2017-12-20 20:41:20 UTC 
I can reproduce this too, same git master build.

Also as the zooming is seen as a "step", it erases any -redo- in front of it, which has a potential of removing entirely some strokes, a definitely unwanted behavior.
Comment 2 Storm Engineer 2017-12-25 19:01:09 UTC 
Some other actions also cause the Edit Guides event, such as transforming.

Since these events create a new history entry it makes Undo-ing very dangerous because this can destroy the steps preventing Redo.
Comment 3 Nicholas LaPointe 2018-01-01 04:44:54 UTC 
This broke with commit 2a1329ec20a3f16a9c2d29bf057da76786cd0e50 ("Add an option to draw ruler tips as a power of 2") and is also the cause of bug 388318.
Comment 4 T Zachmann 2018-01-04 05:32:58 UTC 
Git commit f91fa3c18a0cc8d72f3dab8285fc32993c6f6b7d by Thorsten Zachmann.
Committed on 04/01/2018 at 05:32.
Pushed by zachmann into branch 'master'.

Fix command generated when document is created

Don't create a command when the unit of the document is changed.
Related: bug 388318

M  +1    -1    libs/ui/canvas/kis_guides_manager.cpp

https://commits.kde.org/krita/f91fa3c18a0cc8d72f3dab8285fc32993c6f6b7d
Comment 5 T Zachmann 2018-01-04 05:34:12 UTC 
Git commit 008d4977309776b496a7f38b0764a97bfddc5a8a by Thorsten Zachmann.
Committed on 04/01/2018 at 05:33.
Pushed by zachmann into branch 'krita/3.3'.

Fix command generated when document is created

Don't create a command when the unit of the document is changed.
Related: bug 388318
(cherry picked from commit f91fa3c18a0cc8d72f3dab8285fc32993c6f6b7d)

M  +1    -1    libs/ui/canvas/kis_guides_manager.cpp

https://commits.kde.org/krita/008d4977309776b496a7f38b0764a97bfddc5a8a
Comment 6 Storm Engineer 2018-01-04 14:48:03 UTC 
I can confirm, the issue is fixed.