Bug 387960

Summary: Failed build Calendar tool with kcalcore 17.12
Product: [Applications] digikam Reporter: younker.dl@gmail.com <younky.yang>
Component: Plugin-Generic-CalendarAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 5.7.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In: 5.8.0
Sentry Crash Report:

Description younker.dl@gmail.com 2017-12-16 14:10:43 UTC
kcalcore in kdeapps-17.12 changed the constructor of MemoryCalendar, which broke the build of digikam 5.7.

The error is as below.
[ 52%] Building CXX object utilities/assistants/calendar/CMakeFiles/calendar_src.dir/print/calsettings.cpp.o
/data/portage/media-gfx/digikam-5.7.0-r2/work/digikam-5.7.0/core/utilities/assistants/calendar/print/calsettings.cpp: 在成员函数‘void Digikam::CalSettings::loadSpecial(const QUrl&, const QColor&)’中:
/data/portage/media-gfx/digikam-5.7.0-r2/work/digikam-5.7.0/core/utilities/assistants/calendar/print/calsettings.cpp:293:97: 错误:no matching function for call to ‘KCalCore::MemoryCalendar::MemoryCalendar(QString)’
     KCalCore::MemoryCalendar::Ptr memCal(new KCalCore::MemoryCalendar(QString::fromLatin1("UTC")));
                                                                                                 ^
Comment 1 caulier.gilles 2017-12-16 18:11:36 UTC
Here no problem to compile current digiKam Calendar tool with libkcalcore 17.12 under MXE cross compiler for Windows :

[gilles@localhost calendar]$ make
[  0%] Automatic MOC for target calendar_src
Generating MOC source calendar_src_autogen/MYTF2TZHEE/moc_calpainter.cpp
Generating MOC source calendar_src_autogen/MYTF2TZHEE/moc_calprinter.cpp
Generating MOC source calendar_src_autogen/MYTF2TZHEE/moc_calsettings.cpp
Generating MOC source calendar_src_autogen/WNPF3WE3L6/moc_calmonthwidget.cpp
Generating MOC source calendar_src_autogen/WNPF3WE3L6/moc_caltemplate.cpp
Generating MOC source calendar_src_autogen/WNPF3WE3L6/moc_calwidget.cpp
Generating MOC source calendar_src_autogen/WNPF3WE3L6/moc_calwizard.cpp
Generating MOC compilation calendar_src_autogen/moc_compilation.cpp
[  0%] Built target calendar_src_autogen
[  0%] Generating ui_calprogress.h
[  0%] Generating ui_caltemplate.h
[  0%] Generating ui_calevents.h
Scanning dependencies of target calendar_src
[  0%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/print/calsettings.cpp.obj
[  0%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/print/calpainter.cpp.obj
[  0%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/print/calprinter.cpp.obj
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/print/calsystem.cpp.obj
/mnt/devel/GIT/5.x/core/utilities/assistants/calendar/print/calsystem.cpp: In member function 'int Digikam::CalSystemPrivate::quarter(int) const':
/mnt/devel/GIT/5.x/core/utilities/assistants/calendar/print/calsystem.cpp:459:13: warning: attributes at the beginning of statement are ignored [-Wattributes]
             [[fallthrough]];
             ^
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/wizard/calintropage.cpp.obj
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/wizard/calmonthwidget.cpp.obj
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/wizard/caltemplate.cpp.obj
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/wizard/calwidget.cpp.obj
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/wizard/calwizard.cpp.obj
[100%] Building CXX object core/utilities/assistants/calendar/CMakeFiles/calendar_src.dir/calendar_src_autogen/moc_compilation.cpp.obj
[100%] Built target calendar_src
[gilles@localhost calendar]$ 

Gilles Caulier
Comment 2 caulier.gilles 2017-12-16 20:13:55 UTC
digiKam 5.8.0 and libkcalcore 17.12.0 can be build without any problem under MacoOS through Macports.

Gilles Caulier
Comment 3 caulier.gilles 2017-12-16 20:21:32 UTC
No problem to build digiKam 5.8.0 with libkalcore 17.12 under Linux

Gilles Caulier
Comment 4 younker.dl@gmail.com 2017-12-17 00:28:42 UTC
(In reply to caulier.gilles from comment #3)
> No problem to build digiKam 5.8.0 with libkalcore 17.12 under Linux
> 
> Gilles Caulier

when will 5.8.0 will be officially released?
Comment 5 caulier.gilles 2017-12-17 06:06:43 UTC
next week