| Summary: | Tabbing to navigate in list of results is broken | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Kishore Gopalakrishnan <kishore96> |
| Component: | general | Assignee: | Kai Uwe Broulik <kde> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | alexander.lohnau, bugseforuns, kdebugs |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | 5.19.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Kishore Gopalakrishnan
2017-12-16 06:23:26 UTC
I encounter the issue, *visually*. My interpretation is different. Namely, indeed when one gets a list of options from krunner and wants to select one using up/down arrows (which do not pass settings and close) or tab, only every other option gets highlighted. So, visually, what happens is that one starts with the top option, presses <down> and nothing changes, presses <down> again and now the third options is highlighted. However, when one presses enter after the first <down>, the non-highlighted option that should have been highlighted is triggered. @Kishore: can you test and report back whether your issue is also just visual or not? I'm on Gentoo stable with krunner 5.40.0 and plasma 5.11.5, installed on a system with intel graphics (which seem to cause all kinds of problems). @Kishore: can you let us know which version of krunner you are using? Also, which graphics system do you use? (In reply to Erik Quaeghebeur from comment #1) > I encounter the issue, *visually*. My interpretation is different. > > Namely, indeed when one gets a list of options from krunner and wants to > select one using up/down arrows (which do not pass settings and close) or > tab, only every other option gets highlighted. So, visually, what happens is > that one starts with the top option, presses <down> and nothing changes, > presses <down> again and now the third options is highlighted. However, when > one presses enter after the first <down>, the non-highlighted option that > should have been highlighted is triggered. > > @Kishore: can you test and report back whether your issue is also just > visual or not? > > I'm on Gentoo stable with krunner 5.40.0 and plasma 5.11.5, installed on a > system with intel graphics (which seem to cause all kinds of problems). > > @Kishore: can you let us know which version of krunner you are using? Also, > which graphics system do you use? I can activate the secondary option when it is selected, so it is not purely a visual glitch for me. Right now, krunner --version returns 5.11.5. I am using Intel graphics. I can confirm this issue on KDE Neon Unstable.
>First of all, the tab key also highlights the 'settings' and 'close' button to the left an right of the text box, in addition to other items. While this behaviour is slightly inconvenient, I guess it can be argued that some people might desire this behaviour.
Yes, for instance I am a big fan of this :-).
But when we have the first item selected(also by default when we have typed a query) we expect its first action/the next item to get the focus when pressing tab.
> Yes, for instance I am a big fan of this :-).
I think that it'is very inconvenient. How often do you use close button through TAB key? My opinion is that for choosing second search result I need to press TAB key once not three times... Nearly all keyboard-only oriented shortcuts trying to escape from arrow-keys.
My issue (which I now realize is really different from Kishore's) is fixed in 5.70.0. Kishore's issue is still present. However, I believe it is intended behavior and that one is supposed to select entries using the arrows. That doesn't mean Kishore's preferred behavior may not be reasonable, but it would make it a wish instead of a bug. You are all right about tab vs arrow keys. However, there is one instance of buggy behaviour that persists: Steps to reproduce: 1. Make sure the 'terminate applications' and 'command line' runners are enabled. (Just to make this example work) 2. You are all right about tab vs arrow keys. However, there is one instance of buggy behaviour that persists: Steps to reproduce: 1. Make sure the 'terminate applications' and 'command line' runners are enabled. (Just to make this example work) 2. Type 'kill krun' 3. you will see a result to terminate krunner (the first highlighted result) and another one below it to runn the command 'kill krun' 4. Press tab repeatedly. OBSERVED RESULTS: Tabbing only between the settings button, the textbox, the close button, and the currently highlighted result (terminate krunner). EXPECTED BEHAVIOUR: Tabbing should also iterate over the other returned results, in addition to the close button, secondary actions, etc. PS: Sorry, I accidentally pressed 'save changes' before completing the comment. |