Bug 387933

Summary: "Packages to Remove" pop-up should be modal and have its own close/don't do it button
Product: [Applications] Discover Reporter: Nate Graham <nate>
Component: PackageKitAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: normal Keywords: usability
Priority: NOR    
Version First Reported In: 5.11.4   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: https://commits.kde.org/discover/5f8644a8ea77f2ec7808648af3faab8f9bdcb166 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Pop-up has no "negative" button

Description Nate Graham 2017-12-15 13:58:15 UTC 
Created attachment 109387 [details]
Pop-up has no "negative" button

When an update will remove packages, you get a pop-up telling you about it. However, the pop-up has no button to answer in the negative. You can dismiss the pop-up by clicking outside its borders like any other Kirigami pop-up. Screenshot attached.

This doesn't feel right usability-wise. The pop-up is asking you critically important information that requires user input to proceed, yet it's not modal. Dismissing it by clicking outside the borders feels wrong from a user perspective: are you actually answering in the negative, or just postponing something?

Here are my suggestions:
- Make this UI modal
- Give it a button to answer in the negative that clearly communicates, "no, don't remove those packages"
Comment 1 Aleix Pol 2017-12-15 18:26:53 UTC 
Git commit 5f8644a8ea77f2ec7808648af3faab8f9bdcb166 by Aleix Pol.
Committed on 15/12/2017 at 18:22.
Pushed by apol into branch 'master'.

Add cancel button on the proceed dialog

M  +17   -6    discover/qml/DiscoverWindow.qml

https://commits.kde.org/discover/5f8644a8ea77f2ec7808648af3faab8f9bdcb166
Comment 2 Aleix Pol 2017-12-15 18:27:37 UTC 
I don't really understand why you say it should be modal. If you click outside it cancels the transaction.