Summary: | KConfigGui misbehave at runtime when link time optimizations are enabled | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kconfig | Reporter: | Emmanuel Lepage Vallée <emmanuel.lepage> |
Component: | general | Assignee: | Matthew Dawson <matthew> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | kdelibs-bugs |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Emmanuel Lepage Vallée
2017-12-12 05:38:34 UTC
Sorry if I misunderstand your proposed solution, but it sounds like KConfigCore will then need to make calls into KConfigGui, would require it to be linked together and defeat the purpose of having them separate. I'm not sure how we can make the necessary call across libraries without having the two of them be linked together. Maybe some trickery with the dynamic linker? But that seems error prone, and unlikely to work with LTO. I definitely would like to see this fixed in KConfig though, and making the library more robust against compilers changing is good as well. But I would like to keep KConfigCore from linking against QtGui. kconfigskeleton.cpp is part of KConfigGui, so if the private .h is part of KConfigGui too, then there's no issue. Nothing from KConfigCore is involved. (In reply to Emmanuel Lepage Vallée from comment #2) > kconfigskeleton.cpp is part of KConfigGui, so if the private .h is part of > KConfigGui too, then there's no issue. Nothing from KConfigCore is involved. Sorry, you are correct about that. The name of the class confused me, as I wasn't able to double check that when I replied. As such, I'm generally ok with this plan. My only concern is ensuring that the write happens in a way ensuring that the variables are correctly initialized (through correct acquire/release semantics), but that can be handled in review! If you (or someone else) can write a patch to fix this issue, I'd be happy to review it. Thanks for taking a look into this and LTO! Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |