Bug 387708

That's kind of hard. In the versions of photoshop and psd specification that are available to us, groups cannot have a layer style, so we'd have to reverse engineer a newer psd that has a layer effect attached to the group layer.

But the latest Photoshop supports layer styles for Groups. ((

Here is 2013 video of CS6. 
https://youtu.be/2YlUgOe11OA?t=110

This guy adds Layer Style to a group.

I know it does -- it's just that all I have to test with is CS2 which Adobe made available for general download, and that the file format specification doesn't specify how to add layer styles to group layers (http://www.adobe.com/devnet-apps/photoshop/fileformatashtml/)

Created attachment 109258 [details]
test file

I have added the test file.

I have checked the test file, it seems like PS stores the layer styles for Group Layers in a section with a special ID: 'lfxs'. The rest of the format is exactly the same.

Created attachment 109259 [details]
Test SPD file rom Paul Geraskin

Created attachment 109260 [details]
cs2 erroring out

Just for reference, here's the error cs2 gives when loading that file.

Created attachment 109263 [details]
PSD file saved in Krita

Here is the patch that implements saving and loading of lfxs section for group layers:

https://phabricator.kde.org/P143

Please check if the attached file loads fine in PS. And if so, I will push it into master.

Git commit b34869aca4b645529949c83b485d393931ee612f by Dmitry Kazakov.
Committed on 08/12/2017 at 19:22.
Pushed by dkazakov into branch 'kazakov/lazy-brush-remastered'.

PSD: Implement loading and saving of layer styles for group layers

Photoshop seem to use a special tag for layer styles when used in
the group layers.

M  +6    -3    plugins/impex/psd/psd_additional_layer_info_block.cpp
M  +1    -1    plugins/impex/psd/psd_additional_layer_info_block.h
M  +3    -2    plugins/impex/psd/psd_layer_record.cpp
M  +1    -1    plugins/impex/psd/psd_layer_record.h
M  +2    -1    plugins/impex/psd/psd_layer_section.cpp
M  +6    -0    plugins/impex/psd/psd_loader.cpp

https://commits.kde.org/krita/b34869aca4b645529949c83b485d393931ee612f

Git commit 69f35b85e03fb8fa3da34dd6dc0305f397f5f499 by Dmitry Kazakov.
Committed on 08/12/2017 at 19:24.
Pushed by dkazakov into branch 'master'.

PSD: Implement loading and saving of layer styles for group layers

Photoshop seem to use a special tag for layer styles when used in
the group layers.

M  +6    -3    plugins/impex/psd/psd_additional_layer_info_block.cpp
M  +1    -1    plugins/impex/psd/psd_additional_layer_info_block.h
M  +3    -2    plugins/impex/psd/psd_layer_record.cpp
M  +1    -1    plugins/impex/psd/psd_layer_record.h
M  +2    -1    plugins/impex/psd/psd_layer_section.cpp
M  +6    -0    plugins/impex/psd/psd_loader.cpp

https://commits.kde.org/krita/69f35b85e03fb8fa3da34dd6dc0305f397f5f499

Thank you friends!

Git commit 4d7684291822db6435255b85377ab1409a729a1c by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 22/12/2017 at 12:46.
Pushed by rempt into branch 'krita/3.3'.

PSD: Implement loading and saving of layer styles for group layers

Photoshop seem to use a special tag for layer styles when used in
the group layers.

M  +6    -3    plugins/impex/psd/psd_additional_layer_info_block.cpp
M  +1    -1    plugins/impex/psd/psd_additional_layer_info_block.h
M  +3    -2    plugins/impex/psd/psd_layer_record.cpp
M  +1    -1    plugins/impex/psd/psd_layer_record.h
M  +2    -1    plugins/impex/psd/psd_layer_section.cpp
M  +6    -0    plugins/impex/psd/psd_loader.cpp

https://commits.kde.org/krita/4d7684291822db6435255b85377ab1409a729a1c