| Summary: | Memcheck: make expensive-definedness-checks be the default | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Julian Seward <jseward> |
| Component: | memcheck | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cel, tom |
| Priority: | NOR | ||
| Version First Reported In: | 3.14 SVN | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | WIP patch. Tested on x86, amd64, arm32. | ||
|
Description
Julian Seward
2017-12-07 12:42:42 UTC
Created attachment 109234 [details]
WIP patch. Tested on x86, amd64, arm32.
Needs testing on other platforms, user-level documentation, and some
comment updates. Functionally though I think it's pretty complete.
Patch tested on Power 8 BE, Power 8 LE and Power 9. No regression errors were found on any of the systems. The time command was used to record how long it took to run the regression test. Note, the two power 8 machines were lightly loaded whereas the power 9 system was fairly busy so the run times maybe a little suspect. That said, the overhead of the patch looks to be very small.
The time to run the regression tests are listed below.
base tree patched tree % change
P8 LE real 22m53.848s 22m.42.088s -0.13
user 18m31.216s 18m31.964s 0.067
sys 0m32.700s 0m33.796s 0.29
P8 LE real 31m55.201s 32m39.012s 0.46
user 27m48.776s 28m27.808s 0.45
sys 0m38.604s 0m43.320s 2.86
P9 LE real 0m58.134s 11m1.152s 2.29
user 9m54.270s 9m59.954s 2.34
sys 1m29.456s 1m31.806s 12.20
I'm not seeing any significant slowdown on x86_64 with the kind of typical use I would make of memcheck. Here's the current release version: 2466.53user 11.03system 42:21.37elapsed 97%CPU (0avgtext+0avgdata 9265420maxresident)k and git master with the patch: 2574.74user 5.21system 43:49.79elapsed 98%CPU (0avgtext+0avgdata 9250704maxresident)k Tom, Carl, thanks for the perf measurements. The main patch landed as commit e847cb5429927317023d8410c3c56952aa47fb08. memcheck/tests/vbit-test/vbit-test is now failing, because of the increased accuracy with which some IROps are now instrumented. Fixing that is in progress. (In reply to Julian Seward from comment #4) > memcheck/tests/vbit-test/vbit-test is now failing, because of the increased > accuracy with which some IROps are now instrumented. Fixing that is in > progress. Fixed in 0f18cfc986f800b107c7eee063b8b7c04617e0b8. I think this can be closed now. |