| Summary: | Error dialog is displayed when enter Dashboard and Conjugations were practiced before | ||
|---|---|---|---|
| Product: | [Applications] parley | Reporter: | Hartmut Riesenbeck <hartmut.riesenbeck> |
| Component: | general | Assignee: | parley bug tracker <parley-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | simonandric5 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/parley/c931d920049395f17e84b0eb3ea7edeb35bdd085 | Version Fixed In: | |
| Attachments: | Screen shoot of error message | ||
Git commit c931d920049395f17e84b0eb3ea7edeb35bdd085 by Hartmut Riesenbeck. Committed on 11/12/2017 at 20:13. Pushed by hriesenbeck into branch 'master'. [Parley] Fix false error message when entering dashboard Summary: When entering dashboard with conjugations as current practice mode, an error message box is shown when no entries are due for practice. It says: "The vocabulary document contains no entries that can be used for the chosen type of practice." For determining the word count of the collection widgets, the EntryFilter class is used. A missing test for the showDialg flag was added in the conjugation entries evaluation. Reviewers: #kde_edu, apol Reviewed By: apol Subscribers: apol Tags: #kde_edu Differential Revision: https://phabricator.kde.org/D9246 M +1 -1 src/collection/entryfilter.cpp https://commits.kde.org/parley/c931d920049395f17e84b0eb3ea7edeb35bdd085 |
Created attachment 109230 [details] Screen shoot of error message When last practice session was conjugation practice and currently no vocable are due, an error message is displayed when the application starts or dashboard is entered from statistics window. The error text is: "The vocabulary document contains no entries that can be used for the chosen type of practice." After closing the dialog, parley works without problems. Steps to Reproduce: 1) Start Parley 2) Open a vocable document for practice 3) Practice conjugations until no unpracticed vocable is left 4) Leave practice mode as it is 5) Save document 6) Go to dashboard or restart application Actual Results: The above mentioned error dialog is displayed. Expected Results: No error dialog should be displayed. Version: Build from latest source code from git repository. origin/Applications/17.12