Summary: | Ftp::ftpOpenDir should not emit error unless it really failed | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Wei-Cheng Pan <legnaleurc> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdelibs-bugs, nate |
Priority: | NOR | ||
Version: | 5.37.0 | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/bc4ea213b1d948b921236db29e78846c34496db7 | Version Fixed In: | 5.43 |
Attachments: | do not emit error for "list -la" |
Description
Wei-Cheng Pan
2017-12-06 07:40:12 UTC
Created attachment 109222 [details]
do not emit error for "list -la"
Proved to work on my machine.
What KDE Frameworks version and distro are you using? Debian Unstable, and the packaged version is 5.37.0. Please use https://phabricator.kde.org/differential/diff/create/ to submit patches. Wei-Cheng, can you please submit your patch using phabricator.kde.org? Sorry for late reply. Here is the review request: https://phabricator.kde.org/D9672 Git commit bc4ea213b1d948b921236db29e78846c34496db7 by David Faure, on behalf of Wei-Cheng Pan. Committed on 04/02/2018 at 17:07. Pushed by dfaure into branch 'master'. kio_ftp: don't emit error signal before we tried all list commands. Use a special error code to skip error reporting. FIXED-IN: 5.43 M +6 -2 src/ioslaves/ftp/ftp.cpp https://commits.kde.org/kio/bc4ea213b1d948b921236db29e78846c34496db7 |