Bug 387589

Summary: Incorrect 'Widgets Unlocked' notification appears after undoing removal of 'Folder View' desktop widget
Product: [Plasma] plasmashell Reporter: Alexander Mentyu <notuxius>
Component: generalAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, kde, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.11.4   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-desktop/7e2801974ab58e1a3a72c3ebd7e2d98b0c97b5eb Version Fixed/Implemented In: 5.11.5
Sentry Crash Report:

Description Alexander Mentyu 2017-12-04 14:42:15 UTC 
1. Add 'Folder View' widget to the desktop.
2. Remove it from the desktop.
3. Undo removal of the widget with 'Widget Removed' notification.
Comment 1 Kai Uwe Broulik 2017-12-06 09:57:11 UTC 
FTR: When a widget is removed, it becomes "system immutable" so it cannot be removed by someone else before it's purged by the timeout. When this is undone, the widget gets its old immutability back and triggers the notification.
Comment 2 Kai Uwe Broulik 2017-12-06 10:00:41 UTC 
Patch: https://phabricator.kde.org/D9222 (simpler approach than the one described)
Comment 3 Kai Uwe Broulik 2017-12-07 12:51:13 UTC 
Git commit 7e2801974ab58e1a3a72c3ebd7e2d98b0c97b5eb by Kai Uwe Broulik.
Committed on 07/12/2017 at 12:48.
Pushed by broulik into branch 'Plasma/5.11'.

[Folder View] Show "Widgets unlocked" help only for containment

When removing a widget it turns system-immutable, when undoing it regains its old immutability
triggering the notification.
Rather than tracking whether immutability changed from system- or user-immutability, just don't
spawn the notification if not a containment, which makes sense anyway.
FIXED-IN: 5.11.5

Differential Revision: https://phabricator.kde.org/D9222

M  +1    -1    containments/desktop/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/7e2801974ab58e1a3a72c3ebd7e2d98b0c97b5eb