Summary: | Error response is not handled correctly in EwsGetFolderRequest | ||
---|---|---|---|
Product: | [Frameworks and Libraries] Akonadi | Reporter: | Stefan Brüns <stefan.bruens> |
Component: | EWS Resource | Assignee: | Krzysztof Nowicki <krissn> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | krissn |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kdepim-runtime/05546e3dfd84dcdfd80a84f14f57b9a874ce4db2 | Version Fixed In: | |
Attachments: | Handle Error in GetFolderResponseMessage |
Description
Stefan Brüns
2017-12-04 12:05:48 UTC
Created attachment 109204 [details]
Handle Error in GetFolderResponseMessage
Git commit fb676a19e8d4655ec50f5fbf111df3fc650835f5 by Stefan Brüns. Committed on 03/05/2018 at 22:39. Pushed by bruns into branch 'master'. Handle Error in GetFolderResponseMessage Summary: In case a Folder which no longer exists is updated, the server responds with a GetFolderResponseMessage with ResponseClass="Error". This happens if the internal cache still contains a folder, but the folder has been deleted meanwhile (e.g. through the web client). The message contains an empty Folders element which has to be skipped, otherwise the outer loop for the GetFolderResponseMessages will try to traverse the (nonexisting) Folders element on readNextStartElement. Test Plan: Create a new folder (either using web client or kontact) Make sure it appears in kontact Delete it in the web client (or using kontact on another computer) Try to sync the resource Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: #kde_pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D12475 M +5 -1 resources/ews/ewsclient/ewsgetfolderrequest.cpp https://commits.kde.org/kdepim-runtime/fb676a19e8d4655ec50f5fbf111df3fc650835f5 Git commit 05546e3dfd84dcdfd80a84f14f57b9a874ce4db2 by Stefan Brüns. Committed on 03/05/2018 at 22:39. Pushed by bruns into branch 'master'. Handle Error in GetFolderResponseMessage Summary: In case a Folder which no longer exists is updated, the server responds with a GetFolderResponseMessage with ResponseClass="Error". This happens if the internal cache still contains a folder, but the folder has been deleted meanwhile (e.g. through the web client). The message contains an empty Folders element which has to be skipped, otherwise the outer loop for the GetFolderResponseMessages will try to traverse the (nonexisting) Folders element on readNextStartElement. Test Plan: Create a new folder (either using web client or kontact) Make sure it appears in kontact Delete it in the web client (or using kontact on another computer) Try to sync the resource Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: #kde_pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D12475 https://commits.kde.org/kdepim-runtime/05546e3dfd84dcdfd80a84f14f57b9a874ce4db2 |