Bug 387446

Summary:	Build fails with Qt 5.10
Product:	[Unmaintained] choqok	Reporter:	Christophe Marin <christophe>
Component:	general	Assignee:	Mehrdad Momeny <mehrdad.momeny>
Status:	RESOLVED FIXED
Severity:	normal	CC:	scarpino
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/choqok/c4f22aad945c58864c67a815f775fd82f974389b	Version Fixed In:	1.7
Sentry Crash Report:

Description Christophe Marin 2017-11-29 19:25:33 UTC

Due to a change in QtNetworkAuth, Choqok doesn't build anymore with Qt 5.10.

Commit 24b2d5662 removes QOAuth1::signature which Choqok needs

(https://github.com/qt/qtnetworkauth/commit/24b2d5662)

Comment 1 Andrea Scarpino 2017-12-08 23:22:28 UTC

Git commit 1a4b87f8d200690b90666536ace0b70a28701b89 by Andrea Scarpino.
Committed on 08/12/2017 at 23:21.
Pushed by scarpino into branch 'master'.

Fix build with Qt 5.10

M  +16   -2    helperlibs/twitterapihelper/twitterapioauth.cpp
M  +14   -2    microblogs/pumpio/pumpiooauth.cpp

https://commits.kde.org/choqok/1a4b87f8d200690b90666536ace0b70a28701b89

Comment 2 Christophe Marin 2017-12-09 20:57:22 UTC

Thanks. Builds fine now, but the twitter accounts remains empty. Removing / Adding back the account still results in 
choqok(9820) - org.kde.choqok.twitterapi: : Error: "Could not authenticate you."

Comment 3 Andrea Scarpino 2017-12-10 09:44:45 UTC

(In reply to Christophe Giboudeaux from comment #2)
> Thanks. Builds fine now, but the twitter accounts remains empty. Removing /
> Adding back the account still results in 
> choqok(9820) - org.kde.choqok.twitterapi: : Error: "Could not authenticate
> you."

Unfortunately I can confirm this regression. It also affects Pump.IO. I'm on it.

Comment 4 Andrea Scarpino 2017-12-21 20:23:13 UTC

The regression has been caused by a regression in Qt 5.10.0: https://bugreports.qt.io/browse/QTBUG-65422

Comment 5 Andrea Scarpino 2017-12-22 01:28:31 UTC

Git commit c4f22aad945c58864c67a815f775fd82f974389b by Andrea Scarpino.
Committed on 22/12/2017 at 01:25.
Pushed by scarpino into branch 'master'.

Use QOAuth1Signature instead of QOAuth1::signature

QOAuth1::signature has been removed in 5.10.0 and QOAuth1Signature
should be used instead (exists since 5.8.0). However in 5.10.0 there's a
regression and it requires a patch to work (see QTBUG-65422).

M  +7    -11   helperlibs/twitterapihelper/twitterapioauth.cpp
M  +7    -11   microblogs/pumpio/pumpiooauth.cpp

https://commits.kde.org/choqok/c4f22aad945c58864c67a815f775fd82f974389b