Bug 387438

Summary:	i18n messages from localFileConfiguration/ extracted twice
Product:	[Applications] Elisa	Reporter:	Alexander Potashev <aspotashev>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Potashev 2017-11-29 13:24:50 UTC

i18n messages from localFileConfiguration/ are extracted twice:
  1. by Messages.sh
  2. by localFileConfiguration/Messages.sh

Thus we have duplicate messages between kcm_elisa_local_file.pot and elisa.pot. Please exclude localFileConfiguration/ when extracting to elisa.pot or rearrange source code directories so that there are no common subtrees covered by two Messages.sh.

Comment 1 Matthieu Gallien 2017-11-29 21:35:50 UTC

Hello,
thanks for the report.
I will try to fix that but exact intended behavior is not clear to me.
As far as I have understood, I have to provide the to different messages catalogs. I will fix the extracting scripts.

Comment 2 Alexander Potashev 2017-11-29 22:06:53 UTC

intended behaviour: https://phabricator.kde.org/D9062

It's up to you whether to have two message catalogs or pile everything up into elisa.pot, but since there already is kcm_elisa_local_file.pot (for some reason?), I hesitate to change the approach.

Comment 3 Matthieu Gallien 2017-11-30 20:04:36 UTC

Fixed by commit 3356f57940bbcec29a78b4c32304cdde9a340094