Bug 387429

Summary: Krusader can't be compiled using Ubuntu 16.04 LTS?
Product: [Applications] krusader Reporter: Toni Asensi Esteve <toni.asensi>
Component: generalAssignee: Krusader Bugs Distribution List <krusader-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: alex.bikadorov, krusader-bugs-null
Priority: NOR    
Version First Reported In: Git   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Toni Asensi Esteve 2017-11-29 08:54:56 UTC
Hi!

It seems that Krusader can't be compiled using Ubuntu 16.04 LTS, the latest Long Term Service version. The error given is:

/home/tasensi/krusader/krusader/FileSystem/defaultfilesystem.cpp: In member function ‘virtual void DefaultFileSystem::dropFiles(const QUrl&, QDropEvent*)’:
/home/tasensi/krusader/krusader/FileSystem/defaultfilesystem.cpp:107:25: error: ‘connectJob’ was not declared in this scope
     connectJob(job, dest);
                         ^

Thanks!
/home/tasensi/krusader/krusader/FileSystem/defaultfilesystem.cpp:108:83: error: ‘connectSourceFileSystem’ was not declared in this scope
     connectSourceFileSystem(job, KUrlMimeData::urlsFromMimeData(event->mimeData()));
Comment 1 Toni Asensi Esteve 2017-11-29 09:50:40 UTC
Sorry, I meant:

Hi!

It seems that Krusader can't be compiled using Ubuntu 16.04 LTS, the latest Long Term Service version. The error given is:

/home/tasensi/krusader/krusader/FileSystem/defaultfilesystem.cpp: In member function ‘virtual void DefaultFileSystem::dropFiles(const QUrl&, QDropEvent*)’:
/home/tasensi/krusader/krusader/FileSystem/defaultfilesystem.cpp:107:25: error: ‘connectJob’ was not declared in this scope
    connectJob(job, dest);
                        ^

/home/tasensi/krusader/krusader/FileSystem/defaultfilesystem.cpp:108:83: error: ‘connectSourceFileSystem’ was not declared in this scope
    connectSourceFileSystem(job, KUrlMimeData::urlsFromMimeData(event->mimeData()));

Thanks!
Comment 2 Toni Asensi Esteve 2017-11-29 09:51:32 UTC
This is related information about software versions:

$ dpkg -l | grep -i qtbase
ii  qtbase5-dev:amd64                             5.5.1+dfsg-16ubuntu7.5                       amd64        Qt 5 base development files
ii  qtbase5-dev-tools                             5.5.1+dfsg-16ubuntu7.5                       amd64        Qt 5 base development programs

$ dpkg -l | grep -i kf5core
ii  libkf5coreaddons-bin-dev                      5.18.0-0ubuntu1.1                            amd64        KDE Frameworks 5 addons to QtCore - development files
ii  libkf5coreaddons-data                         5.18.0-0ubuntu1.1                            all          KDE Frameworks 5 addons to QtCore - data files
ii  libkf5coreaddons-dev:amd64                    5.18.0-0ubuntu1.1                            amd64        KDE Frameworks 5 addons to QtCore - development files
ii  libkf5coreaddons5:amd64                       5.18.0-0ubuntu1.1                            amd64        KDE Frameworks 5 addons to QtCore

$ dpkg -l | grep -i kio
ii  kio                                           5.18.0-0ubuntu1.1                            amd64        Resource and network access abstraction.
ii  kio-dev                                       5.18.0-0ubuntu1.1                            amd64        Resource and network access abstraction.
ii  kio-extras                                    4:15.12.3-0ubuntu1                           amd64        Extra functionality for kioslaves.
ii  kio-extras-data                               4:15.12.3-0ubuntu1                           all          Extra functionality for kioslaves data files.
ii  libkf5kiocore5:amd64                          5.18.0-0ubuntu1.1                            amd64        Resource and network access abstraction.
ii  libkf5kiofilewidgets5:amd64                   5.18.0-0ubuntu1.1                            amd64        Resource and network access abstraction.
ii  libkf5kiontlm5:amd64                          5.18.0-0ubuntu1.1                            amd64        Resource and network access abstraction.
ii  libkf5kiowidgets5:amd64                       5.18.0-0ubuntu1.1                            amd64        Resource and network access abstraction.
ii  libkio5                                       4:4.14.16-0ubuntu3.2                         amd64        Network-enabled File Management Library for the KDE Platform
Comment 3 Alex Bikadorov 2017-11-29 21:08:13 UTC
Hi, thanks for reporting. Please test with latest master.

[Automatic IDE refactoring is evil with #if macros.]
Comment 4 Toni Asensi Esteve 2017-11-30 13:13:49 UTC
Thanks! It works using an Ubuntu 16.04 virtual machine, and using an Ubuntu 16.04 computer. Nice!

Although the name of the commit (
    "FileSystem: Fix compile error with Qt < 5.30"
related to the line 
    #if KIO_VERSION >= QT_VERSION_CHECK(5, 30, 0)
of "defaultfilesystem.cpp" sounds strange :-)
Though it's not too important :-)