Bug 387330

Summary:	uninitialized variable warnings for PlotDataDialog
Product:	[Applications] LabPlot2	Reporter:	uwestoehr <uwestoehr>
Component:	frontend	Assignee:	Alexander Semke <alexander.semke>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	latest
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/labplot/e0e4702b80b24861e9336fcd1b2e0a677db85c04	Version Fixed/Implemented In:	2.5
Sentry Crash Report:

Description uwestoehr 2017-11-27 00:01:12 UTC

I get:

2>C:\CraftRoot\labplot\src\kdefrontend\spreadsheet\PlotDataDialog.cpp(184): warning C4946: reinterpret_cast used between related classes: 'QWidget' and 'SpreadsheetView'
2>c:\craftroot\labplot\src\kdefrontend\spreadsheet\plotdatadialog.cpp(471): warning C4701: potentially uninitialized local variable 'analysisCurve' used
2>c:\craftroot\labplot\src\kdefrontend\spreadsheet\plotdatadialog.cpp(471): warning C4703: potentially uninitialized local pointer variable 'analysisCurve' used

Comment 1 uwestoehr 2017-11-30 13:29:22 UTC

Many thanks, the variable is now initialized. However this warning remains and seems to be valid:

1>C:\CraftRoot\labplot\src\kdefrontend\spreadsheet\PlotDataDialog.cpp(184): warning C4946: reinterpret_cast used between related classes: 'QWidget' and 'SpreadsheetView'

Comment 2 Alexander Semke 2017-12-02 10:12:44 UTC

Git commit e0e4702b80b24861e9336fcd1b2e0a677db85c04 by Alexander Semke.
Committed on 02/12/2017 at 10:10.
Pushed by asemke into branch 'master'.

Remove reinterpred_casts in the part views.
FIXED-IN: 2.5

M  +8    -6    src/backend/cantorWorksheet/CantorWorksheet.cpp
M  +3    -1    src/backend/cantorWorksheet/CantorWorksheet.h
M  +15   -28   src/backend/core/AbstractPart.cpp
M  +21   -22   src/backend/core/AbstractPart.h
M  +10   -8    src/backend/core/Workbook.cpp
M  +4    -0    src/backend/core/Workbook.h
M  +9    -4    src/backend/datapicker/Datapicker.cpp
M  +4    -1    src/backend/datapicker/Datapicker.h
M  +11   -12   src/backend/datapicker/DatapickerImage.cpp
M  +2    -0    src/backend/datapicker/DatapickerImage.h
M  +3    -3    src/backend/datasources/LiveDataSource.cpp
M  +20   -23   src/backend/matrix/Matrix.cpp
M  +1    -0    src/backend/matrix/Matrix.h
M  +9    -10   src/backend/note/Note.cpp
M  +31   -28   src/backend/note/Note.h
M  +10   -12   src/backend/spreadsheet/Spreadsheet.cpp
M  +2    -0    src/backend/spreadsheet/Spreadsheet.h
M  +12   -16   src/backend/worksheet/Worksheet.cpp
M  +2    -0    src/backend/worksheet/Worksheet.h

https://commits.kde.org/labplot/e0e4702b80b24861e9336fcd1b2e0a677db85c04

Comment 3 Alexander Semke 2017-12-02 10:17:51 UTC

reinterpret casts are  not wrong per se. In many places they lead to some cumbersome expressions in the code - I refactored this part. The remaining couple of reinterpret_casts, also in PlotDataDialog mentioned here, won't be removed.