Bug 387197

Summary:	compiler warnings with XYDataReductionCurve
Product:	[Applications] LabPlot2	Reporter:	uwestoehr <uwestoehr>
Component:	backend	Assignee:	Alexander Semke <alexander.semke>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	latest
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description uwestoehr 2017-11-21 22:57:20 UTC

I get:

2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(129): warning C4625: 'XYDataReductionCurveSetDataReductionDataCmd': copy constructor was implicitly defined as deleted
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(129): warning C5026: 'XYDataReductionCurveSetDataReductionDataCmd': move constructor was implicitly defined as deleted
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(129): warning C4626: 'XYDataReductionCurveSetDataReductionDataCmd': assignment operator was implicitly defined as deleted
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(129): warning C5027: 'XYDataReductionCurveSetDataReductionDataCmd': move assignment operator was implicitly defined as deleted
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(131): warning C4458: declaration of 'd' hides class member
2>  C:\CraftRoot\labplot\src\backend/core/AbstractAspect.h(183): note: see declaration of 'AbstractAspect::d'
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(238): warning C4365: 'initializing': conversion from 'int' to 'unsigned int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(238): warning C4365: 'initializing': conversion from 'int' to 'const unsigned int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(276): warning C4365: 'argument': conversion from 'int' to 'const std::size_t', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(309): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(309): warning C4365: 'argument': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(310): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(310): warning C4365: 'argument': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(312): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(312): warning C4365: 'argument': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(313): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(313): warning C4365: 'argument': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(349): warning C4458: declaration of 'd' hides class member
2>  C:\CraftRoot\labplot\src\backend/core/AbstractAspect.h(183): note: see declaration of 'AbstractAspect::d'
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(393): warning C4458: declaration of 'd' hides class member
2>  C:\CraftRoot\labplot\src\backend/core/AbstractAspect.h(183): note: see declaration of 'AbstractAspect::d'
2>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(436): warning C4365: '=': conversion from 'int' to 'std::size_t', signed/unsigned mismatch

Comment 1 uwestoehr 2017-11-22 23:31:45 UTC

I now only get this:

1>C:\CraftRoot\labplot\src\backend/lib/commandtemplates.h(57): warning C4371: 'StandardSetterCmd<XYDataReductionCurve::Private,const AbstractColumn *>': layout of class may have changed from a previous version of the compiler due to better packing of member 'StandardSetterCmd<XYDataReductionCurve::Private,const AbstractColumn *>::m_field'
1>  C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(103): note: see declaration of 'StandardSetterCmd<XYDataReductionCurve::Private,const AbstractColumn *>'
1>  C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(103): note: see reference to class template instantiation 'StandardSetterCmd<XYDataReductionCurve::Private,const AbstractColumn *>' being compiled

Comment 2 uwestoehr 2017-11-25 15:35:50 UTC

This is now fixed.

Comment 3 uwestoehr 2017-11-28 21:08:17 UTC

Not fully fixed. I get:

1>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\XYDataReductionCurve.cpp(230): warning C4365: 'argument': conversion from 'int' to 'const std::size_t', signed/unsigned mismatch

Comment 4 uwestoehr 2017-12-05 00:06:45 UTC

This is now fixed.