Bug 387196

Summary:	conditional expression is constant warnings in XYFitCurveDock
Product:	[Applications] LabPlot2	Reporter:	uwestoehr <uwestoehr>
Component:	frontend	Assignee:	Alexander Semke <alexander.semke>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description uwestoehr 2017-11-21 22:44:04 UTC

I get these warnings:

2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(152): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(153): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(154): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(156): warning C4566: character represented by universal-character-name '\u0304' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(157): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(158): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(211): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(285): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(343): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(361): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(376): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(391): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(406): warning C4127: conditional expression is constant
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(513): warning C4365: 'argument': conversion from 'unsigned int' to 'int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(514): warning C4365: 'argument': conversion from 'unsigned int' to 'int', signed/unsigned mismatch
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(848): warning C4566: character represented by universal-character-name '\u221E' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(862): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(864): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(867): warning C4566: character represented by universal-character-name '\u0304' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(870): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(892): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(966): warning C4566: character represented by universal-character-name '\u03C7' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(999): warning C4566: character represented by universal-character-name '\u221E' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(1001): warning C4566: character represented by universal-character-name '\u221E' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(1010): warning C4566: character represented by universal-character-name '\u221E' cannot be represented in the current code page (1252)
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(1128): warning C4458: declaration of 'data' hides class member
2>  C:\Qt\Qt5.9.2\5.9.2\msvc2015_64\include\QtWidgets/qwidget.h(733): note: see declaration of 'QWidget::data'
2>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(1134): warning C4365: 'argument': conversion from 'unsigned int' to 'int', signed/unsigned mismatch

Comment 1 Alexander Semke 2017-11-22 11:16:33 UTC

We use unicode in the source files. You'll need to switch from the code page 1252 to unicode on your side.

Other warning (conversion from uint to int and the hiding of 'data') will be addressed.

Comment 2 uwestoehr 2017-11-22 23:26:49 UTC

> You'll need to switch from the code page 1252 to unicode on your side.

The MSVC project uses Unicode. The problem is that one needs to use a wide char according to
https://msdn.microsoft.com/de-de/library/5zkb5h07.aspx

Comment 3 uwestoehr 2017-12-05 00:23:29 UTC

Despite the Unicode warnings, I get this:

1>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(220): warning C4365: 'initializing': conversion from 'int' to 'unsigned int', signed/unsigned mismatch
1>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(225): warning C4365: '=': conversion from 'unsigned int' to 'int', signed/unsigned mismatch
1>C:\CraftRoot\labplot\src\kdefrontend\dockwidgets\XYFitCurveDock.cpp(514): warning C4365: '=': conversion from 'unsigned int' to 'int', signed/unsigned mismatch

Comment 4 uwestoehr 2017-12-13 20:32:16 UTC

This bug was fixed today.