Summary: | Untranslatable placeholders in csv importer | ||
---|---|---|---|
Product: | [Applications] kmymoney | Reporter: | Burkhard Lück <lueck> |
Component: | importer | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
Status: | REPORTED --- | ||
Severity: | normal | CC: | ralf.habacker |
Priority: | NOR | ||
Version: | 4.8.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Bug Depends on: | |||
Bug Blocks: | 403474 | ||
Attachments: | error dialog csv import |
Description
Burkhard Lück
2017-11-19 18:04:36 UTC
I must be missing something, but I do see them translatable (here for example from the bankingwizardpage.cpp, the others are similar): // initialize column names m_dlg->m_colTypeName.insert(Column::Payee,i18n("Payee")); m_dlg->m_colTypeName.insert(Column::Number,i18n("Number")); m_dlg->m_colTypeName.insert(Column::Debit,i18n("Debit")); m_dlg->m_colTypeName.insert(Column::Credit,i18n("Credit")); m_dlg->m_colTypeName.insert(Column::Date,i18n("Date")); m_dlg->m_colTypeName.insert(Column::Amount,i18n("Amount")); m_dlg->m_colTypeName.insert(Column::Category,i18n("Category")); m_dlg->m_colTypeName.insert(Column::Memo,i18n("Memo")); What is it, that I don't see? Created attachment 109054 [details]
error dialog csv import
@Thomas Baumgart: you look at the wrong strings, see attached screenshot
@Burkhard Lueck: I looked at the right one, but did so in master. The problem only exists in 4.8.x as the CSV importer looks a bit different in KF5. My code referred to the KF5 (aka master) branch. The related code is: cvsdialog.cpp:1786 KMessageBox::information(0, i18n("<center>The '<b>%1</b>' field already has this column selected.</center>" "<center>Please reselect both entries as necessary.</center>", m_columnTypeList[col])); where m_columnTypeList[col] contains untranslated entries. Should they be wrapped with an i18n() call ? Got no answer, will be retested with 4.8.4 |