Bug 387119

Summary:	loss of data warnings with nsl_filter.c
Product:	[Applications] LabPlot2	Reporter:	uwestoehr <uwestoehr>
Component:	backend	Assignee:	Stefan Gerlach <stefan.gerlach>
Status:	RESOLVED FIXED
Severity:	normal	CC:	stefan.gerlach
Priority:	NOR
Version First Reported In:	latest
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/labplot/972af51b575ea8d529f00d4dbbdab0152d6f0193	Version Fixed/Implemented In:	2.5
Sentry Crash Report:

Description uwestoehr 2017-11-19 18:03:34 UTC

I get:

4>C:\CraftRoot\labplot\src\backend\nsl\nsl_filter.c(47): warning C4204: nonstandard extension used: non-constant aggregate initializer
4>C:\CraftRoot\labplot\src\backend\nsl\nsl_filter.c(72): warning C4244: '=': conversion from 'double' to 'std::size_t', possible loss of data
4>C:\CraftRoot\labplot\src\backend\nsl\nsl_filter.c(164): warning C4244: '=': conversion from 'double' to 'std::size_t', possible loss of data
4>C:\CraftRoot\labplot\src\backend\nsl\nsl_filter.c(212): warning C4244: '=': conversion from 'double' to 'std::size_t', possible loss of data
4>C:\CraftRoot\labplot\src\backend\nsl\nsl_filter.c(317): warning C4710: 'int printf(const char *const ,...)': function not inlined
4>  C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt\../ucrt/stdio.h(944): note: see declaration of 'printf'
4>  nsl_fit.c

Comment 1 uwestoehr 2017-11-21 22:40:54 UTC

Is now fixed.

Comment 2 uwestoehr 2017-11-21 23:02:10 UTC

Reopening because I get this:

2>C:\CraftRoot\labplot\src\backend\nsl\nsl_filter.c(164): warning C4244: '=': conversion from 'double' to 'std::size_t', possible loss of data

Comment 3 Stefan Gerlach 2017-11-22 18:11:32 UTC

Git commit 972af51b575ea8d529f00d4dbbdab0152d6f0193 by Stefan Gerlach.
Committed on 22/11/2017 at 17:49.
Pushed by sgerlach into branch 'master'.

FIXED-IN: 2.5

M  +1    -1    src/backend/nsl/nsl_filter.c

https://commits.kde.org/labplot/972af51b575ea8d529f00d4dbbdab0152d6f0193

Comment 4 uwestoehr 2017-11-22 23:11:55 UTC

Thanks, now only this  on appears:

3>C:\CraftRoot\include\msvc\stdlib.h(53): warning C4255: 'random': no function prototype given: converting '()' to '(void)'

(Appears for many files.)

Comment 5 Stefan Gerlach 2017-11-23 22:30:30 UTC

This is a warning for the system C header stdlib.h. It's not our code ...