Bug 387114

Summary:	loss of data warnings with NetCDFFilter
Product:	[Applications] LabPlot2	Reporter:	uwestoehr <uwestoehr>
Component:	backend	Assignee:	Stefan Gerlach <stefan.gerlach>
Status:	RESOLVED FIXED
Severity:	normal	CC:	stefan.gerlach
Priority:	NOR
Version First Reported In:	latest
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/labplot/e4b86ce024dfa772837c11c5aaf46466bf5cf31f	Version Fixed/Implemented In:	2.5
Sentry Crash Report:

Description uwestoehr 2017-11-19 17:48:55 UTC

4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(536): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(536): warning C4365: '=': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(559): warning C4365: 'initializing': conversion from 'int' to 'std::size_t', signed/unsigned mismatch
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(561): warning C4365: 'initializing': conversion from 'int' to 'std::size_t', signed/unsigned mismatch
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(580): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
I get:

4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(580): warning C4365: '=': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(584): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(584): warning C4365: '=': conversion from 'std::size_t' to 'int', signed/unsigned mismatch
4>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(614): warning C4365: 'argument': conversion from 'unsigned int' to 'int', signed/unsigned mismatch

Comment 1 Stefan Gerlach 2017-11-22 21:04:10 UTC

Git commit c573873f8abf1889606a4c5ee413b9229035918f by Stefan Gerlach.
Committed on 22/11/2017 at 21:03.
Pushed by sgerlach into branch 'master'.

FIXED-IN:2.5

M  +7    -7    src/backend/datasources/filters/NetCDFFilter.cpp

https://commits.kde.org/labplot/c573873f8abf1889606a4c5ee413b9229035918f

Comment 2 uwestoehr 2017-11-27 00:28:54 UTC

Not fixed. Now I get:

3>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(614): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
3>C:\CraftRoot\labplot\src\backend\datasources\filters\NetCDFFilter.cpp(614): warning C4365: 'argument': conversion from 'std::size_t' to 'int', signed/unsigned mismatch

Comment 3 Stefan Gerlach 2017-11-28 20:47:23 UTC

Git commit e4b86ce024dfa772837c11c5aaf46466bf5cf31f by Stefan Gerlach.
Committed on 28/11/2017 at 20:46.
Pushed by sgerlach into branch 'master'.

FIXED-IN: 2.5

M  +1    -1    src/backend/datasources/filters/NetCDFFilter.cpp

https://commits.kde.org/labplot/e4b86ce024dfa772837c11c5aaf46466bf5cf31f