Bug 387017

Summary: function override warnings in column/Column.h and core/AbstractColumn.h
Product: [Applications] LabPlot2 Reporter: uwestoehr <uwestoehr>
Component: backendAssignee: Alexander Semke <alexander.semke>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: latest   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/labplot/b026e35cbebd399871d8cfb015dbc1cb58a761a9 Version Fixed/Implemented In:
Sentry Crash Report:

Description uwestoehr 2017-11-16 23:30:17 UTC 
I get:

2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(80): warning C4373: 'Column::formula': virtual function overrides 'AbstractColumn::formula', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(166): note: see declaration of 'AbstractColumn::formula'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(89): warning C4373: 'Column::textAt': virtual function overrides 'AbstractColumn::textAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(172): note: see declaration of 'AbstractColumn::textAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(90): warning C4373: 'Column::setTextAt': virtual function overrides 'AbstractColumn::setTextAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(173): note: see declaration of 'AbstractColumn::setTextAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(91): warning C4373: 'Column::replaceTexts': virtual function overrides 'AbstractColumn::replaceTexts', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(174): note: see declaration of 'AbstractColumn::replaceTexts'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(92): warning C4373: 'Column::dateAt': virtual function overrides 'AbstractColumn::dateAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(175): note: see declaration of 'AbstractColumn::dateAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(93): warning C4373: 'Column::setDateAt': virtual function overrides 'AbstractColumn::setDateAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(176): note: see declaration of 'AbstractColumn::setDateAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(94): warning C4373: 'Column::timeAt': virtual function overrides 'AbstractColumn::timeAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(177): note: see declaration of 'AbstractColumn::timeAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(95): warning C4373: 'Column::setTimeAt': virtual function overrides 'AbstractColumn::setTimeAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(178): note: see declaration of 'AbstractColumn::setTimeAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(96): warning C4373: 'Column::dateTimeAt': virtual function overrides 'AbstractColumn::dateTimeAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(179): note: see declaration of 'AbstractColumn::dateTimeAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(97): warning C4373: 'Column::setDateTimeAt': virtual function overrides 'AbstractColumn::setDateTimeAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(180): note: see declaration of 'AbstractColumn::setDateTimeAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(98): warning C4373: 'Column::replaceDateTimes': virtual function overrides 'AbstractColumn::replaceDateTimes', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(181): note: see declaration of 'AbstractColumn::replaceDateTimes'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(99): warning C4373: 'Column::valueAt': virtual function overrides 'AbstractColumn::valueAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(182): note: see declaration of 'AbstractColumn::valueAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(100): warning C4373: 'Column::setValueAt': virtual function overrides 'AbstractColumn::setValueAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(183): note: see declaration of 'AbstractColumn::setValueAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(101): warning C4373: 'Column::replaceValues': virtual function overrides 'AbstractColumn::replaceValues', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(184): note: see declaration of 'AbstractColumn::replaceValues'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(102): warning C4373: 'Column::integerAt': virtual function overrides 'AbstractColumn::integerAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(185): note: see declaration of 'AbstractColumn::integerAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(103): warning C4373: 'Column::setIntegerAt': virtual function overrides 'AbstractColumn::setIntegerAt', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(186): note: see declaration of 'AbstractColumn::setIntegerAt'
2>C:\CraftRoot\labplot\src\backend/core/column/Column.h(104): warning C4373: 'Column::replaceInteger': virtual function overrides 'AbstractColumn::replaceInteger', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
2>  C:\CraftRoot\labplot\src\backend/core/AbstractColumn.h(187): note: see declaration of 'AbstractColumn::replaceInteger'
Comment 1 Alexander Semke 2017-11-17 07:50:55 UTC 
Git commit b026e35cbebd399871d8cfb015dbc1cb58a761a9 by Alexander Semke.
Committed on 17/11/2017 at 07:49.
Pushed by asemke into branch 'master'.

Removed unneeded const's in the overridden functions in Column.
FIX-IN: 2.5

M  +18   -17   src/backend/core/column/Column.h

https://commits.kde.org/labplot/b026e35cbebd399871d8cfb015dbc1cb58a761a9