| Summary: | "pure virtual function called" from Phabricator plugin | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-purpose | Reporter: | RJVB <rjvbertin> |
| Component: | general | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | my current workaround patch | ||
|
Description
RJVB
2017-11-15 17:32:27 UTC
Created attachment 108879 [details]
my current workaround patch
I'm currently using this workaround, implementing option #3.
Option 2) would require overriding `buildArcCommand()` in all child classes, which feels heavy-handed would undo much of the interest of the DifferentialRevision parent class.
Well, wait, this means we are doing a wrong cast, no? We - or maybe rather the runtime, unlikely as that sound - so we're probably doing something else wrong (but we aren't casting anything here; maybe we should?) The way this is designed is - the base class provides a QProcess and connects a signal from that QProcess to a purely virtual slot - derived classes have to provide the implementation for that slot - the derived slot is the only one that should ever be called (evidently) `DiffRevList` is the only derived class that provides its own `buildArcCommand` implementation and that thus has to connect m_arcCmd's `finished` signal to its overridden `done` slot. I'm getting a bit lost here; why would m_arcCmd::finished be connected to DifferentialRevision::done if DifferentialRevision::buildArcCommand() isn't called (because overridden)? Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |