Bug 386729

Summary:	Preview dialog should close on pressing Escape
Product:	[Applications] ark	Reporter:	Kai Uwe Broulik <kde>
Component:	general	Assignee:	Elvis Angelaccio <elvis.angelaccio>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate, rthomsen6
Priority:	NOR
Version First Reported In:	17.11.70
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/ark/ae758226b8b630572de715054b4b965443a4ef11	Version Fixed In:	17.11.80
Sentry Crash Report:

Description Kai Uwe Broulik 2017-11-10 23:02:19 UTC

The preview dialog is a typical popup dialog with a dedicated "Close" button in the corner but pressing Escape does not dismiss it. It should do that to ease browsing multiple files. I'm not sure how this will affect different preview plugins but with image and text previews there's no conflicts.

Comment 1 Elvis Angelaccio 2017-11-14 22:46:38 UTC

Git commit ae758226b8b630572de715054b4b965443a4ef11 by Elvis Angelaccio.
Committed on 14/11/2017 at 22:43.
Pushed by elvisangelaccio into branch 'Applications/17.12'.

ArkViewer: close on Escape
FIXED-IN: 17.11.80

Test Plan:
Open preview for a text file, then check whether Esc closes the window.
If some operation is happening in the kate part (e.g. text selected, or search bar open),
make sure Esc aborts the operation rather than closing the window.

Reviewed By: broulik

Differential Revision: D8761

M  +1    -0    part/arkviewer.cpp

https://commits.kde.org/ark/ae758226b8b630572de715054b4b965443a4ef11