Bug 386655

Summary: "Launch" button overlaps "Remove" button
Product: [Applications] Discover Reporter: Patrick Silva <bugseforuns>
Component: discoverAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: screenshot

Description Patrick Silva 2017-11-08 18:03:24 UTC
Created attachment 108749 [details]
screenshot

See my screenshot taked on neon dev unstable please.
Comment 1 Nate Graham 2017-11-08 18:15:24 UTC
Probably a corner case introduced alongside https://cgit.kde.org/discover.git/commit/?id=b8096e9dea4fc29242d4d11212793fb06e117eb8
Comment 2 Nate Graham 2017-11-08 18:17:39 UTC
In particular perhaps

-                    spacing: 0
+                    spacing: Kirigami.Units.largeSpacing
Comment 3 Aleix Pol 2017-11-08 18:19:59 UTC
Git commit 8ce81b2a8e4607e449779318bfd90ddabc7f957a by Aleix Pol.
Committed on 08/11/2017 at 18:17.
Pushed by apol into branch 'master'.

Improve displaying very long names on the application page header

M  +42   -45   discover/qml/ApplicationPage.qml
M  +1    -0    discover/qml/ConditionalLoader.qml

https://commits.kde.org/discover/8ce81b2a8e4607e449779318bfd90ddabc7f957a
Comment 4 Nate Graham 2017-11-08 18:27:40 UTC
Now that was the fastest bugfix in history!
Comment 5 Christoph Feck 2017-11-08 19:37:22 UTC
The fastest were under one minute, https://bugs.kde.org/weekly-bug-summary.cgi?tops=10&days=7300
Comment 6 Nate Graham 2017-11-08 19:55:59 UTC
Goodness, that's amazing.