| Summary: | The ID field now includes an icon in 3.1 compared to 3.0.2 | ||
|---|---|---|---|
| Product: | [Applications] tellico | Reporter: | Bruno Cornec <bruno> |
| Component: | general | Assignee: | Robby Stephenson <robby> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | NOR | ||
| Version: | 3.1 | ||
| Target Milestone: | --- | ||
| Platform: | Mageia RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/tellico/c84cf02da262986c2f3b29aefab98fade9f90311 | Version Fixed In: | 3.1.1 |
| Sentry Crash Report: | |||
| Attachments: | table view with icons in double | ||
Git commit c84cf02da262986c2f3b29aefab98fade9f90311 by Robby Stephenson. Committed on 12/11/2017 at 22:01. Pushed by rstephenson into branch 'master'. Add an ENtryIconModel to separate entry icon handling from EntryModel As a side effect, the DetailedEntryView no longer shows an entry icon in any column other than the image columns themselves. Also, for the moment, EntryIconModel doesn't handle remote image requests as EntryModel does. FIXED-IN: 3.1.1 M +4 -0 ChangeLog M +21 -0 src/entryiconview.cpp M +2 -0 src/entryiconview.h M +4 -1 src/mainwindow.cpp M +1 -0 src/models/CMakeLists.txt A +118 -0 src/models/entryiconmodel.cpp [License: GPL (v2/3)] C +20 -27 src/models/entryiconmodel.h [from: src/entryiconview.h - 065% similarity] M +1 -55 src/models/entrymodel.cpp M +1 -5 src/models/entrymodel.h M +6 -1 src/tests/tellicomodeltest.cpp https://commits.kde.org/tellico/c84cf02da262986c2f3b29aefab98fade9f90311 Git commit 9ba3c5ad2bb830614a954edb8b6a701b25863aa0 by Robby Stephenson. Committed on 17/11/2017 at 01:56. Pushed by rstephenson into branch 'master'. Improve EntryIconModel to act more as proxy for EntryModel for images Add a new data role to designate the primary image for an entry. Break out the image request for the model into a separate method so multiple places can use it. Also, use an icon for the EntryModel instead of a pixmap which solves problems of weirdly big images in the tree view. M +2 -2 src/collection.cpp M +1 -1 src/collection.h M +0 -1 src/mainwindow.cpp M +14 -19 src/models/entryiconmodel.cpp M +38 -13 src/models/entrymodel.cpp M +1 -0 src/models/entrymodel.h M +2 -1 src/models/models.h https://commits.kde.org/tellico/9ba3c5ad2bb830614a954edb8b6a701b25863aa0 |
Created attachment 108714 [details] table view with icons in double I upgraded to tellico 3.1 and pushed the update to Mageia (Thanks Robby, for this program I daily uses and is vital for me !) It seems tere is a regression with this version compared to 3.0.2. In the table area on the right, where columns are printed, now inside the ID column, (as well as in the Title column) there is an icon. I don't think that's useful, as now I have it twice (Cf screenshot). Maybe the best approach would be to have an icon column that people could display when and where they want instead of sticking it to a specific column. Minor anyway.