Summary: | System Settings Sporadically Crashes | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | yo |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | simonandric5 |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.11.2 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kamera/5bc0682c3a1e80d1a35691896816f2475eb3905f | Version Fixed In: | |
Sentry Crash Report: |
Description
yo
2017-11-04 18:48:21 UTC
*** This bug has been marked as a duplicate of bug 305061 *** Git commit 5bc0682c3a1e80d1a35691896816f2475eb3905f by David Edmundson. Committed on 22/03/2018 at 01:00. Pushed by davidedmundson into branch 'master'. Fix dangly pointer if gp_context_new fails Summary: m_deviceModel is typically created in the constructor, except in the code path where m_context fails. At this point we have a dangly pointer that the rest of the code uses uncondiationally Safer code path is to just create it earlier, we want this object in the non-error case anyway Test Plan: Purely code reading I've not got a fancy camera Reviewers: #plasma Differential Revision: https://phabricator.kde.org/D11564 M +2 -1 kcontrol/kamera.cpp https://commits.kde.org/kamera/5bc0682c3a1e80d1a35691896816f2475eb3905f |