Bug 386497

Summary: Pixel brush engine crashes Krita after some time
Product: [Applications] krita Reporter: Vladimir Savic <vladimir.firefly.savic>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: alvin
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Attachments: crash report

Description Vladimir Savic 2017-11-03 16:09:52 UTC
Created attachment 108696 [details]
crash report

Appveyor version run in the Win10 crashes after some time with big brush sizes (> 500px). There is no specific action besides just doodling around. Crash happens every time, though. And usually after a few minutes of drawing.

First time experienced after merging multithreaded-brushes branch.

Attaching kritacrash file.
Comment 1 Alvin Wong 2017-11-03 16:13:47 UTC
Today's AppVeyor build is at 47d52592, for the record.
Comment 2 Alvin Wong 2017-11-03 16:20:49 UTC
Hi, please also download the debug package. The appveyor build should contain a link to the specific version of debugging symbols for the build (the versions must match for it to work). You can follow https://docs.krita.org/Dr._Mingw_debugger to extract the files at the correct location.

After that, you can delete your existing kritacrash.log and try to reproduce the crash again, this time there should be more information in kritacrash.log to help debug this issue.
Comment 3 Alvin Wong 2017-11-03 17:06:29 UTC
Marking this as a duplicate since Bug 386498 has a more detailed backtrace.

*** This bug has been marked as a duplicate of bug 386498 ***
Comment 4 Dmitry Kazakov 2017-11-24 22:16:33 UTC
Git commit d123397f6118a038e182e9e51a959bf7372c4cb9 by Dmitry Kazakov.
Committed on 24/11/2017 at 22:16.
Pushed by dkazakov into branch 'master'.

Fix a crash in the multithreaded brush

The cached value of 'lastDabJobInQueue' was calculated incorrectly.

Ref T7309
Related: bug 386498, bug 386523

The fix might also affect the crash in 386523, but I'm not sure about it

M  +3    -1    plugins/paintops/defaultpaintops/brush/KisDabRenderingQueue.cpp

https://commits.kde.org/krita/d123397f6118a038e182e9e51a959bf7372c4cb9