Bug 386458

Summary: libtaskmanager test-suite depends on external resources – dolphin, konversation
Product: [Plasma] plasmashell Reporter: h.goebel
Component: Task Manager and Icons-Only Task Manager widgetsAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: major CC: kde, lemmyg, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.11.2   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description h.goebel 2017-11-02 13:08:41 UTC 
The test-suite for libtaskmanager fails if dolphin and konversations are not installed (see below).

The reason is that launchertasksmodeltest is not self-contained, but tries to explicitly access 
file:///usr/share/applications/org.kde.dolphin.desktop and
file:///usr/share/applications/org.kde.konversation.desktop

$./libtaskmanager/autotests/launchertasksmodeltest                         
********* Start testing of LauncherTasksModelTest *********
Config: Using QtTest library 5.9.2, Qt 5.9.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.4.0)
PASS   : LauncherTasksModelTest::initTestCase()
FAIL!  : LauncherTasksModelTest::shouldRoundTripLauncherUrlList() Compared values are not the same
   Actual   (m.data(m.index(0, 0), AbstractTasksModel::LauncherUrl).toString()): "file:///usr/share/applications/org.kde.dolphin.desktop"
   Expected (m_mangledUrlStrings.at(0))                                        : "applications:org.kde.dolphin.desktop"
   Loc: [/tmp/guix-build-plasma-workspace-5.11.2.drv-0/plasma-workspace-5.11.2/libtaskmanager/autotests/launchertasksmodeltest.cpp(70)]
PASS   : LauncherTasksModelTest::shouldIgnoreInvalidUrls()
PASS   : LauncherTasksModelTest::shouldRejectDuplicates()
PASS   : LauncherTasksModelTest::shouldAddRemoveLauncher()
PASS   : LauncherTasksModelTest::shouldReturnValidLauncherPositions()
PASS   : LauncherTasksModelTest::shouldReturnValidData()
PASS   : LauncherTasksModelTest::cleanupTestCase()
Totals: 7 passed, 1 failed, 0 skipped, 0 blacklisted, 48ms
********* Finished testing of LauncherTasksModelTest *********


How to reproduce
======================

Uninstall dolphin and konversations and run the test-quite.


What I'd expect
=====================

1) The test-suite should be self-contined.
2) Esp. it should not depend on such big and high-level applications like
   doplhin and konversations.



Proposed solution
=====================

Copy (stripped) versions of org.kde.dolphin.desktop and org.kde.konversation.desktop into the
test-suite and use it from here.
Comment 2 galder 2022-01-30 15:33:18 UTC 
Looks like an old issue. Setting it to needs more info.
Please if this is not an issue any more let us know.
Bugs placed into NEEDSINFO status will receive a reminder if the ticket:

    Is at least 15 days old
    Has not received any comment within 15 days

If a bug remains in NEEDSINFO for another 15 days with no comment, it will be closed as RESOLVED > WORKSFORME.
Comment 3 h.goebel 2022-02-07 08:41:23 UTC 
Since nobody has been working on this issue and this si s build-time issue, I assume this is still valid.
Comment 4 galder 2022-02-07 09:46:32 UTC 
if this is an issue that the team is planning to work in some point.
Would not be better to move it to confirmed?
Comment 5 h.goebel 2022-02-07 09:51:03 UTC 
(In reply to galder from comment #4)
> if this is an issue that the team is planning to work in some point.
> Would not be better to move it to confirmed?

I'm the reporter (and not a team member), so I don't feel entitled to change to confirmed.
Comment 6 galder 2022-02-07 10:10:15 UTC 
"Since nobody has been working on this issue and this si s build-time issue, I assume this is still valid."
did you try it in a recent version?