Bug 386375

Summary: part 3: compiler warnings with LabPlot 2.4.0 in AUR
Product: [Applications] LabPlot2 Reporter: uwestoehr <uwestoehr>
Component: generalAssignee: Alexander Semke <alexander.semke>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 2.4.0   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 2.5
Sentry Crash Report:

Description uwestoehr 2017-10-31 01:59:31 UTC
Grabbing LabPlot from AUR (Arch Linux) the compilation issues some warnings that might be fixable. Here are the last ones:

[ 55%] Building CXX object src/CMakeFiles/labplot2.dir/backend/spreadsheet/SpreadsheetModel.cpp.o
/tmp/pamac-build-usti/labplot-kf5/src/labplot-2.4.0-kf5/src/backend/spreadsheet/SpreadsheetModel.cpp: In member function ‘virtual QVariant SpreadsheetModel::data(const QModelIndex&, int) const’:
/tmp/pamac-build-usti/labplot-kf5/src/labplot-2.4.0-kf5/src/backend/spreadsheet/SpreadsheetModel.cpp:130:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if(!col_ptr->isValid(index.row()))
    ^~
/tmp/pamac-build-usti/labplot-kf5/src/labplot-2.4.0-kf5/src/backend/spreadsheet/SpreadsheetModel.cpp:133:3: note: here
   case MaskingRole:
   ^~~~