Bug 386336

Summary:	Fix compilation with link time optimizations
Product:	[Unmaintained] ring-kde	Reporter:	Emmanuel Lepage Vallée <emmanuel.lepage>
Component:	general	Assignee:	Emmanuel Lepage Vallée <emmanuel.lepage>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/ring-kde/9c0f05208bde876db850db4c351b6efd4ac2ae43	Version Fixed/Implemented In:
Sentry Crash Report:

Description Emmanuel Lepage Vallée 2017-10-29 21:41:59 UTC

There is a bunch of errors with -flto=8. Some seem to have to do with exported symbols visibility being broken. Maybe the use of "final" in some classes makes it worst.

One way or another it should be fixed if the app is ever deployed on mobile.

Comment 1 Emmanuel Lepage Vallée 2017-10-31 02:55:00 UTC

Git commit 9c0f05208bde876db850db4c351b6efd4ac2ae43 by Emmanuel Lepage Vallee.
Committed on 30/10/2017 at 01:47.
Pushed by lepagevalleeemmanuel into branch 'kirigami'.

lto: Fix the photo selector plugin

M  +4    -0    src/photoselector/photoplugin.cpp
M  +3    -1    src/photoselector/photoplugin.h
M  +1    -1    src/photoselector/photoselector.cpp
M  +1    -1    src/photoselector/photoselector.h

https://commits.kde.org/ring-kde/9c0f05208bde876db850db4c351b6efd4ac2ae43