Summary: | Akregator crashes when opening configuration dialog if "Show Tray Icon" is disabled | ||
---|---|---|---|
Product: | [Applications] akregator | Reporter: | Omar Plummer <omarplummer> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | GIT (master) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/akregator/683749ec6391fc7b1fe4e2a43f15f12ebe482f02 | Version Fixed In: |
Description
Omar Plummer
2017-10-29 16:09:50 UTC
Ok, having now taken a look at the code, I realise that my wording of the original bug report was somewhat misguided. What actually seems to be happening here is a null pointer de-reference. On line 659 of src/akregator_part.cpp, the Akregator systray icon instance (NULL when disabled) is being set up as the receiver of a signal. By simply wrapping that call to "connect()" in a conditional that checks that the result of TrayIcon::getInstance() is not "falsy", the problem appears to be resolved. Git commit 683749ec6391fc7b1fe4e2a43f15f12ebe482f02 by Montel Laurent. Committed on 30/10/2017 at 14:52. Pushed by mlaurent into branch 'master'. Fix Bug 386328 - Akregator crashes when opening configuration dialog if "Show Tray Icon" is disabled M +4 -2 src/akregator_part.cpp M +1 -1 src/trayicon.cpp https://commits.kde.org/akregator/683749ec6391fc7b1fe4e2a43f15f12ebe482f02 |