Bug 386258

Summary:	Does not recognize C++ override keyword
Product:	[Applications] umbrello	Reporter:	Shoshana Biro <sbiro>
Component:	importer	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	major
Priority:	NOR
Version:	2.23.1 (KDE Applications 17.08.1)
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/umbrello/63595fabca6cb088869f0a22f2c89efaa492c8e8	Version Fixed In:	2.23.80 (KDE Applications 17.11.80)
Sentry Crash Report:

Description Shoshana Biro 2017-10-27 17:01:19 UTC

Umbrello Version 2.23.2, KDE platform version 4.14.60.
It seems that from your bug fixes the "override" bug was fixed a few years ago.
However it still failed to import on my Windows 10 with Visual Studio 2017 installed. In the log it says:
error: Syntax Error before 'override'
So I removed the word 'override' and tried the import again. It worked fine.

Comment 1 Ralf Habacker 2017-10-31 11:16:27 UTC

Git commit 63595fabca6cb088869f0a22f2c89efaa492c8e8 by Ralf Habacker.
Committed on 31/10/2017 at 11:15.
Pushed by habacker into branch 'master'.

Fix 'Does not recognize C++ override keyword'
FIXED-IN:2.23.80 (KDE Applications 17.11.80)
Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>

M  +6    -0    lib/cppparser/ast.cpp
M  +8    -0    lib/cppparser/ast.h
M  +3    -0    lib/cppparser/ast_utils.cpp
M  +1    -0    lib/cppparser/keywords.h
M  +1    -0    lib/cppparser/lexer.h
M  +21   -0    lib/cppparser/parser.cpp
M  +2    -0    umbrello/codegenerators/cpp/cppheadercodeoperation.cpp
M  +2    -0    umbrello/codegenerators/cpp/cppsourcecodeoperation.cpp
M  +3    -0    umbrello/codegenerators/cpp/cppwriter.cpp
M  +4    -0    umbrello/codeimport/kdevcppparser/cpptree2uml.cpp
M  +6    -2    umbrello/dialogs/pages/codeimportoptionspage.cpp
M  +7    -0    umbrello/dialogs/pages/codeimportoptionspage.ui
M  +9    -1    umbrello/dialogs/umloperationdialog.cpp
M  +1    -0    umbrello/dialogs/umloperationdialog.h
M  +5    -0    umbrello/optionstate.cpp
M  +3    -1    umbrello/optionstate.h
M  +5    -0    umbrello/umbrello.kcfg
M  +21   -0    umbrello/uml1model/operation.cpp
M  +3    -0    umbrello/uml1model/operation.h
M  +2    -2    umbrello/version.h

https://commits.kde.org/umbrello/63595fabca6cb088869f0a22f2c89efaa492c8e8

Comment 2 Ralf Habacker 2018-04-08 22:34:12 UTC

Git commit 4381b76bd1933eac4f650396627deba8f6e41528 by Ralf Habacker.
Committed on 08/04/2018 at 22:29.
Pushed by habacker into branch 'master'.

Fixup of 63595fabc - document xmi attribute 'isVirtual'

The xmi attribute 'isVirtual' has been added by the related commit.
The attribute is umbrello specific and therefore located in
uml-1.4-umbrello.dtd.

M  +2    -0    doc/xml/uml-1.4-umbrello.dtd

https://commits.kde.org/umbrello/4381b76bd1933eac4f650396627deba8f6e41528