Bug 386245

Summary:	dialog gets stuck on error
Product:	[Frameworks and Libraries] flatpak-platform-plugin	Reporter:	Harald Sitter <sitter>
Component:	general	Assignee:	Jan Grulich <jgrulich>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, jgrulich
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch to fix this issue

Description Harald Sitter 2017-10-27 11:44:21 UTC

They way I read it

void QFlatpakFileDialog::exec()

has a problem with error handling. It async calls the portal, but then in the finished slot it does nothing more than qDebug that there was an error before starting an eventloop which is now going to block indefinitely as there was an error already.

Supposedly it should return after the qdebugs AND maybe throw up a qmessagebox whining about the problem visually.

Comment 1 Jan Grulich 2017-10-30 08:04:17 UTC

I think emitting just that the dialog was rejected in case there is an error should be enough. Unfortunately I don't think there is a way how to show a message box. Any other opinion?

Comment 2 Jan Grulich 2017-10-30 08:05:36 UTC

Created attachment 108640 [details]
Patch to fix this issue

Attaching patch which I think is enough to fix this problem.

Comment 3 Aleix Pol 2017-10-30 10:18:58 UTC

If you want review for patches, please use phabricator...

Comment 4 Jan Grulich 2017-10-30 10:36:29 UTC

Ooook, sorry: https://phabricator.kde.org/D8552

Comment 5 Jan Grulich 2017-10-30 11:41:42 UTC

Git commit a2ab3c860f3327773897746a3e7870ee37a14fe9 by Jan Grulich.
Committed on 30/10/2017 at 12:41.
Pushed by jgrulich into branch 'master'.

Exit when we fail to open file dialog

Summary:
When we fail to send a dbus call to open a file dialog, we just show an
error, but problem is that at the end we start a loop and wait until
user confirms the dialog and we get response back, which we never get
if we fail to open the dialog.

Reviewers: apol, sitter

Reviewed By: apol, sitter

Subscribers: sitter

Differential Revision: https://phabricator.kde.org/D8552