| Summary: | okular: CMake Error in generators/spectre/CMakeLists.txt | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Eugene Shalygin <eugene.shalygin+bugzilla.kde> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | luigi.toscano, nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/okular/f777e2a9241c4f384f60c467e226eee85fb5bc98 | Version Fixed In: | |
| Sentry Crash Report: | |||
Thanks for finding this! Would you be able to submit a patch on https://phabricator.kde.org/? > Would you be able to submit a patch on https://phabricator.kde.org/?
No, this is a trivial change.
But first, before thinking about a patch, can it be reproduced elsewhere? I can't test it right now, but our Jenkins server seems still happy. I use cmake 3.10 rc3. Maybe this version is stricter. Anyway, okular_add_generator() calls a function from kf5 which creates a plugin. Could a plugin be not a MODULE? Git commit f777e2a9241c4f384f60c467e226eee85fb5bc98 by Henrik Fehlauer. Committed on 03/11/2017 at 23:25. Pushed by rkflx into branch 'master'. Fix CMake Error in generators/spectre/CMakeLists.txt Summary: When porting from `add_library` to `okular_add_generator`, 2f9246ae42ce missed to remove `MODULE` for spectre, which is already implicitly added as can be seen [here](https://phabricator.kde.org/source/kcoreaddons/browse/master/KF5CoreAddonsMacros.cmake;83623a46c9862ee37535de93427dec0b0c55e24d$139). This causes the upcoming CMake 3.10 to print the error `Cannot find source file`, which can be fixed by removing the superfluous `MODULE`. Test Plan: No error shown anymore with CMake 3.10.0-rc4. Still works with CMake 3.5.1. Reviewers: #okular, ngraham Reviewed By: ngraham Tags: #okular Differential Revision: https://phabricator.kde.org/D8612 M +1 -1 generators/spectre/CMakeLists.txt https://commits.kde.org/okular/f777e2a9241c4f384f60c467e226eee85fb5bc98 |
CMake Error in generators/spectre/CMakeLists.txt: Cannot find source file: MODULE Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx apparently, "MODULE" argument is unneeded in okular_add_generator() call