Summary: | Selecting text moves it one pixel towards the bottom | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Oliver Sander <oliver.sander> |
Component: | general | Assignee: | David Edmundson <kde> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | aacid, kde, simonandric5 |
Priority: | NOR | ||
Version: | 1.2.70 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Oliver Sander
2017-10-23 14:25:00 UTC
I don't think i can reproduce it either (you mean Ctrl+4, right?) Could you link the file you're using and maybe some screenshots? > I don't think i can reproduce it either (you mean Ctrl+4, right?)
No, I mean Ctrl+3.
I found out that it has to do with display scaling. On my system,
~/okular(master)> echo $QT_SCREEN_SCALE_FACTORS
eDP-1=1.5;DP-1=1.5;HDMI-1=1.5;HDMI-2=1.5;DP-1-1=1.5;DP-1-2=1.5;DP-1-3=1.5;
If I replace all these 1.5 by 1.0 then the bug disappears.
yes, i can reproduce when using QT_SCALE_FACTOR=1.5 Git commit 804d0bd42a23488a6bbd8090ee2590871ddeb64e by David Edmundson. Committed on 09/04/2018 at 21:58. Pushed by davidedmundson into branch 'Applications/18.04'. Fix rubber band selection drawing contents misaligned with scaling Summary: in drawPixmap(source, sourceRect) the source rect is in native pixels. In this code the size was scaled by the DPR, but the location was not. blendRect is the contents of a selection rectangle, offset from the bounding darker blue rectangle. Hence we haven't really noticed. This completely fixes the rectangle when the scale == 2.0/3.0 Some smaller artifacts remain on fractional scale factors, which is a separate code bug with the same symptoms. Reviewers: aacid, rkflx Reviewed By: rkflx Subscribers: sander, rkflx, anthonyfieroni, #okular Tags: #okular Differential Revision: https://phabricator.kde.org/D8980 M +3 -2 ui/pageview.cpp https://commits.kde.org/okular/804d0bd42a23488a6bbd8090ee2590871ddeb64e |