| Summary: | k3b-master/src/projects/k3bvcdburndialog.cpp:62: lots of missing breaks ? | ||
|---|---|---|---|
| Product: | [Applications] k3b | Reporter: | dcb314 |
| Component: | general | Assignee: | K3b Bugs <k3b-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | michalm, nate, trueg |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/k3b/d6686bb0ce07601f2f980cdf001c472ea37e027e | Version Fixed In: | |
| Sentry Crash Report: | |||
Git commit d6686bb0ce07601f2f980cdf001c472ea37e027e by Leslie Zhai. Committed on 13/10/2017 at 03:13. Pushed by lesliezhai into branch 'master'. Fix switch stmt missing break issue. A patch by dcb314@hotmail.com! M +10 -6 src/projects/k3bvcdburndialog.cpp https://commits.kde.org/k3b/d6686bb0ce07601f2f980cdf001c472ea37e027e |
switch ( m_vcdDoc->vcdType() ) { case K3b::VcdDoc::VCD11: vcdType = i18n( "Video CD (Version 1.1)" ); case K3b::VcdDoc::VCD20: vcdType = i18n( "Video CD (Version 2.0)" ); case K3b::VcdDoc::SVCD10: vcdType = i18n( "Super Video CD" ); case K3b::VcdDoc::HQVCD: vcdType = i18n( "High-Quality Video CD" ); default: vcdType = i18n( "Video CD" ); } Whoever wrote this seemingly didn't test it AND isn't very familiar with coding in C++. Suggest code rework, preferably by an experienced C++ programmer.